Closed Bug 511721 Opened 10 years ago Closed 10 years ago

Add unlinked .xpts to removed-files.in for OS X

Categories

(Thunderbird :: Build Config, defect)

All
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.1a1

People

(Reporter: philor, Assigned: standard8)

References

Details

Attachments

(1 file)

Since bug 510309 started linking .xpts on OS X, we need an #ifndef MOZILLA_1_9_1_BRANCH, #ifdef XP_MAC section in mail/installer/removed-files.in equivalent to the

# ****************************************************************************
# * Remove the XPTs that were present at the time (2009-04) when we started  *
# * linking XPTs on Linux. You almost certainly don't want to add anything   *
# * to this section.                                                         *
# ****************************************************************************

chunk for Linux, or more likely since the lists should be substantially the same, just ifdef a few differences inside that list and turn it into both Linux and OS X.
Attached patch The fixSplinter Review
I downloaded the 2009/08/19 nightly and looked at components/*.xpt. I adjusted the list so that we get Linux and Mac first, then there's a few xpts that have been added to the code since we started linking on Linux so they are mac only. Finally there's a few Linux only files.
Assignee: nobody → bugzilla
Status: NEW → ASSIGNED
Attachment #395811 - Flags: review?(philringnalda)
Comment on attachment 395811 [details] [diff] [review]
The fix

Looks good, at least by the standards of that horribly tangled file.
Attachment #395811 - Flags: review?(philringnalda) → review+
Checked in: http://hg.mozilla.org/comm-central/rev/799490fea817
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.1a1
You need to log in before you can comment on or make changes to this bug.