511746 - Resource.foo shouldn't throw except in exceptional cases.

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Mike Connor [:mconnor]]

Resource.get() throws on 4xx errors.  This seems wrong, and means we have to catch exceptions to handle network errors, and then propagate upwards to the original caller.  We should only throw if something generally unexpected happens.  Auth failures on login almost certainly shouldn't be unexpected as a valid case to handle.

Comment 1

[Ed Lee :Mardak]

Attachment: v1

Also remove usages of lastChannel, etc.

Comment 2

[Ed Lee :Mardak]

Attachment: v1.1

No more getting down and dirty bit.

It's possible that responses are handled by cache, so there'll be data but no headers, so just use some defaults in that case.

Comment 3

[Ed Lee :Mardak]

Attachment: v1.2

Updated engines to check for failure and throw.

Comment 4

[Dan Mills [:thunder]]

Comment on attachment 396850 [details] [diff] [review]
v1.2

r=thunder

I love the string hack ;)

Comment 5

[Ed Lee :Mardak]

http://hg.mozilla.org/labs/weave/rev/bf3db89a4cbd
Get rid of lastChannel and return a String object from _request with additional properties of status, succeeded, headers -- even if the response was handled by cache. Update engines to check for non-success and throw the failure. Update tests to use these additional properties instead of lastChannel, etc.