511795 - [ForumUX] Change post timestamp to link to a specific post in a thread

Status: VERIFIED FIXED

(support.mozilla.org :: Forum, task)

Description

[[:Cww]]

Right now you can't link to specific posts inside a thread.  This very commonly done in other forums and really useful for contributors to link to which post is a good solution in a given thread or other threads.

Comment 1

[Paul Craciunoiu [:paulc]]

How does adding a javascript "Link to this" button next to each post sound? On click, this will append the required markup in the reply form.

Comment 2

[[:Cww]]

Apparently you can do this already:
http://support.mozilla.com/tiki-view_forum_thread.php?locale=en-US&forumId=1&comments_threshold=0&comments_parentId=413435&comments_offset=60&comments_per_page=20&thread_style=commentStyle_plain#threadId424608
but we don't expose this URL from the UI.

Since you're often linking to a post in a different thread, we might as well just have the link visible and people can copy and paste it themselves.

Comment 3

[James Socol [:jsocol, :james]]

How about adding a title attribute to the link, something along the lines of "Link to this reply"?

Comment 4

[[:Cww]]

This no longer blocks bug 511792 since apparently the functionality needed for that one already exists.

Comment 5

[[:Cww]]

(In reply to comment #3)
If you want to be an overachiever I won't stop you.

Comment 6

[James Socol [:jsocol, :james]]

Attachment: patch, v1

Adds a period (I know about bug 433319 but there are accessibility concerns without it) after the date, two spaces, then a link, with the localizable text "permalink" and localizable title "Link to this post."

Also adds a CSS rule to keep the links from standing out too much. Any suggestions on the style?

(Not linking the post date directly for a11y reasons.)

Comment 7

[Paul Craciunoiu [:paulc]]

Attachment: demo screenshot

Cww: looks good to you? Word "Permalink" ok?

Comment 8

[James Socol [:jsocol, :james]]

Attachment: patch, v2

After talking with Cww, paulc, and Alex from Firefox UI, we redesigned the UI a bit. The "permalink" text is replaced with a hash that's only visible when you mouse over the post, and it looks like a link. (Will post screenshots.)

Comment 9

[James Socol [:jsocol, :james]]

Attachment: Posts, without hovering over one

Here's a post without the mouse over it, and...

Comment 10

[James Socol [:jsocol, :james]]

Attachment: screenshot, hovering on a post

here's what happens when you mouse over a post.

Comment 11

[Paul Craciunoiu [:paulc]]

Comment on attachment 397122 [details] [diff] [review]
patch, v2

Looks good and simple.

Comment 12

[James Socol [:jsocol, :james]]

Attachment: patch, v3

Same as v2, just brought up to date since one of the files changed on me.

Comment 13

[Paul Craciunoiu [:paulc]]

Comment on attachment 397660 [details] [diff] [review]
patch, v3

Didn't test old patch, but assume this was needed because applying the old patch failed.

Comment 14

[James Socol [:jsocol, :james]]

Exactly right. Committed to forumux branch.
r50523

Comment 15

[James Socol [:jsocol, :james]]

Merged to trunk / prod.
r51292 / r51294

Comment 16

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on http://support-stage.mozilla.org/tiki-view_forum_thread.php?locale=en-US&forumId=3&comments_threshold=0&comments_parentId=39569&comments_offset=20&comments_per_page=20&thread_style=commentStyle_plain, with JavaScript enabled/disabled.

Multi-page thread links such as http://support-stage.mozilla.org/tiki-view_forum_thread.php?locale=en-US&forumId=3&comments_threshold=0&comments_parentId=39569&comments_offset=20&comments_per_page=20&thread_style=commentStyle_plain#threadId39569 work well.