Created attachment 395729 [details] [diff] [review] Patch StMNHTIterator needs to keep a reference to the MNHT it is using to keep it from being collected. StMNHTIterator and StTraitsBindingsIterator both need their "keeper" fields to be marked volatile; turns out that agressive optimizing compilers can notice that these fields aren't ever used and omit the store.
Attachment #395729 - Flags: review?(treilly)
Created attachment 396868 [details] [diff] [review] StringIndexer, too StringIndexer needs similar love, too.
Attachment #396868 - Flags: review?(treilly)
Should we have a all our stack utility classes w/ GC pointers be marked volatile?
(In reply to comment #2) > Should we have a all our stack utility classes w/ GC pointers be marked > volatile? Based on what we saw here, yes, potentially. (The issue here was that the "keeper" fields weren't used for anything, so the compiler optimized 'em away. If a GC pointer is actually *used* then the volatile probably isn't necessary.
pushed both to redux as changeset: 2418:8b3c7bde9273
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Resolved fixed engineering / work item that has been pushed. Setting status to verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.