511804 - "Duplicate entry 'user_review_approval" error message trying to move an article from staging -> HTC

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot

As an Admin

1. Load https://support-stage.mozilla.org/tiki-editpage.php?locale=en-US&page=oscar+the+grouch2
2. Move it into the "How to Contribute" category

Expected Results:

Article saves into the HTC category (since you're an Admin)

Actual Results:

An error occured in a database query!

Context:
File	tiki-editpage.php
Url	tiki-editpage.php?locale=en-US
Query:
insert into `tiki_user_watches`(`event`,`object`,`email`) values(?,?,?)
Values:
0	user_review_approval
1	5847
2	[e-mail]
Message:
Duplicate entry 'user_review_approval-5847-' for key 1
Built query was probably:
insert into `tiki_user_watches`(`event`,`object`,`email`) values('user_review_approval','5847','[e-mail]')

Comment 1

[Tom Ellins [:TMZ]]

Ive just checked your article and it appears to be in the HTC category. Maybe im looking wrong (3am here) or maybe it goes through even with the error.

Comment 2

[Paul Craciunoiu [:paulc]]

This seems to work fine for me. Maybe it was my screw-up in bug that caused it.

See:
https://support-stage.mozilla.org/en-US/kb/tplug5?bl=n (created in staging, moved to HTC)
and
https://support-stage.mozilla.org/en-US/kb/tplug4?bl=n (created in staging, moved to KB, then moved to HTC)

However, I did encounter a problem when moving an article from the staging area to the HTC category. This might have to do with bug 498056 -- the article is placed both in staging and HTC.

Stephen, keep playing around and give me some STR with an article starting from scratch if you can.

For now, this doesn't seem to be a new problem.

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

http://screencast.com/t/FxCkrtAx

Comment 4

[Laura Thomson :laura]

Paulc, can you take another look given the screencast?

Comment 5

[Paul Craciunoiu [:paulc]]

I talked to Stephen offline, told him to try with a new article after I saw the screencast. Should've posted here.

Either way, I will look at the code and see what happens on moving HTC article (see comment 2). Might re-summarize this bug once I figure out what happens. At first glance, though, the staging->HTC bug seems related to bug 498056, but the duplicate entry probably happened for other reasons (especially if the page creation timed out).

I couldn't reproduce locally yet.

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

I can't reproduce this anew, but can, only on the article mentioned above.

Comment 7

[Paul Craciunoiu [:paulc]]

Attachment: patch, v1

Thanks Stephen! This bug prompted me to look over my code, and I realized that I missed something.

Patch moves the code for notifying the user when an article has been approved only when the article is actually in the staging area (doh). I'll place that in the bug summary.

This might also fix the duplicate entry issue, but if not, it should at least fix (what I suspect is) the reason it happened.

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Can we get this reviewed today, Laura?  I'd like to continue testing, thanks!

Comment 9

[Paul Craciunoiu [:paulc]]

r50313 / r50314

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; thanks, Paul!