512022 - Remove hyphen on developer's add-on first-run page

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

STR:

Load https://preview.addons.mozilla.org/en-US/firefox/addon/12481/about

"Thank-you for installing..." should be "Thank you for installing..." (no hyphen)

Comment 1

[Milos Dinic [:Milos]]

Attachment: patch v1

Comment 2

[Milos Dinic [:Milos]]

Ryan, sorry for this one. I noticed that it was assigned to you only after I submited a patch.

Comment 3

[Justin Scott [:fligtar]]

It's OK, Ryan hates working on AMO bugs.

Comment 4

[Fred Wenzel [:wenzel]]

Comment on attachment 396009 [details] [diff] [review]
patch v1

That's good, but we also need to change the en-US and all other locale's files, I think. If you want, I can do that for you though.

Comment 5

[Milos Dinic [:Milos]]

As per IRC, we won`t touch l10n stuff.

Note: I don`t have svn commit privs to AMO trunk, so please commit that for me.

Comment 6

[Fred Wenzel [:wenzel]]

I will, but we need to wait until the tree is back open after AMO 5.0.9 has been pushed live, probably on Thursday.

Comment 7

[Milos Dinic [:Milos]]

I think this can be pushed to preview now.

Comment 8

[Fred Wenzel [:wenzel]]

I committed this (along with a search-and-replace on all l10n .po files) to r50633. Thanks, Milos!

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED.