Closed Bug 512049 Opened 15 years ago Closed 15 years ago

TM: inline DoubleToECMAInt32

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
status1.9.2 --- beta1-fixed

People

(Reporter: gal, Assigned: gal)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

patch
6.99 KB, patch
dmandelin
: review+
Details | Diff | Splinter Review 
DoubleToECMAInt32 has a fast path but is pretty long and hence has a ton of spills in the prolog/epilog. This patch moves it to the header file so it can be inlined (its used across 5 files in a couple call sites). This is a small perf with with JIT (1-2ms, hard to measure). Its more obvious in an interp only build, since the interpreter calls DoubleToECMAInt32 more often (3% speedup for some of the SS tests).
Attached patch patch — — Splinter Review 
Assignee: general → gal

        Attachment #396047 -
        Flags: review?(dmandelin)

        Attachment #396047 -
        Flags: review?(dmandelin) → review+

    
    

    
  
http://hg.mozilla.org/tracemonkey/rev/fcd321cd60c1
Whiteboard: fixed-in-tracemonkey

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/fcd321cd60c1
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: