512064 - Reporter extension should be in toolkit.jar, not browser.jar

Status: VERIFIED FIXED

(Firefox Build System :: General, defect)

Description

[Serge Gautherie (:sgautherie)]

Bug 468011 Comment 24: (and followings)
{
From  Philip Chee   2009-08-07 03:11:25 PDT

> --- a/extensions/reporter/jar.mn
> +++ b/extensions/reporter/jar.mn
> @@ -1,4 +1,4 @@
> -reporter.jar:
> +browser.jar:

SeaMonkey does not have a browser.jar. Neither does Thunderbird, Sunbird, etc.
}

I assume no application really care for reporter.jar, but this change is wrong "as is":

1) It should be opt-in:
Make browser.jar be |#ifdef Firefox + Fennec + ...| and keep reporter.jar as a default.

2) port the rest of the "speed enhancement" to all affected apps:
{
     1.2 +++ b/browser/installer/removed-files.in	Fri Aug 14 09:32:40 2009 -0700
     1.3 @@ -1,3 +1,7 @@
     1.6 +chrome/reporter.jar
     1.7 +chrome/reporter.manifest
}
needs to be done for all the other apps.
(And for the new "regression" browser.jar too!)

Then each app can add an |#ifdef| to use its main jar, if/when it wants to.

Comment 1

[Phil Ringnalda (:philor)]

Attachment: s/browser/toolkit/

Erm, no, no, feel free, and no.

Thunderbird, Sunbird, etc. don't care, because they're not in the business of displaying or reporting broken web pages, so they don't build Reporter.

We don't need a spew of ifdefs for shared code, because we already have a single place to put shared code: toolkit.

SM does need to stop trying to package reporter.jar and .manifest, and remove them, ifndef MOZILLA_1_9_1_BRANCH, in a SM build config bug patched by a SM dev, who should probably catch up with half a dozen other things, too.

But, you don't need to remove browser.jar and .manifest, because you've never shipped or packaged them. Even I wouldn't bother removing something for a month worth of Mac-trunk-nightlies, though I might use it as an excuse to port "use a package manifest for OS X, too."

Comment 2

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/mozilla-central/rev/a519afcff3b3

Comment 3

[Serge Gautherie (:sgautherie)]

Toolkit part V.Fixed, per
/pub/seamonkey/nightly/2009/09/2009-09-27-00-comm-central-trunk

Thanks for the additional explanation.
I filed bug 519117.