512080 - nsSystemPrefService.h not copied to objdir/dist/include/system-pref building TB 2.0.0.23

Status: RESOLVED WONTFIX

(Thunderbird :: Build Config, defect)

Description

[Steven Michaud [:smichaud] (Retired)]

The nsSystemPrefService.h header file (used by the system-pref
extension) doesn't get copied to [objdir]/dist/include/system-pref/
when building from the source download for Thunderbird 2.0.0.23.

This makes the build die with errors that I'll attach in my next
comment.

The workaround is to copy nsSystemPrefService.h from
extensions/pref/system-pref/src/gcon/ to
[objdir]/dist/include/system-pref/, then rebuild.

Comment 1

[Steven Michaud [:smichaud] (Retired)]

Attachment: Build errors

Comment 2

[Mark Banner (:standard8)]

Looking at the tinderbox log which continuously builds Thunderbird 2 I see:

...
Creating ../../../../dist/include/system-pref
gmake[7]: Entering directory `/builds/tinderbox/Tb-Mozilla1.8-Nightly/Linux_2.4.18-14_Depend/mozilla/extensions/pref/system-pref/src/gconf'
/builds/tinderbox/Tb-Mozilla1.8-Nightly/Linux_2.4.18-14_Depend/mozilla/config/nsinstall -R -m 644 nsSystemPrefService.h ../../../../../dist/include/system-pref
/builds/tinderbox/Tb-Mozilla1.8-Nightly/Linux_2.4.18-14_Depend/mozilla/config/nsinstall -R ./../nsSystemPrefFactory.cpp .
gmake[7]: Leaving directory `/builds/tinderbox/Tb-Mozilla1.8-Nightly/Linux_2.4.18-14_Depend/mozilla/extensions/pref/system-pref/src/gconf'
...

Full log here: http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla1.8/1250962320.1250962875.17671.gz&fulltext=1

Tinderboxes found here:

http://tinderbox.mozilla.org/Mozilla1.8/

The only way I can see this file not being copied is if MOZ_ENABLE_GTK2 is not set. So you need to make sure you have the default gtk2 toolkit (--enable-default-toolkit=gtk2) which is the default for Linux according to my examination of configure.in

Therefore I suspect your configuration is wrong.

Comment 3

[Steven Michaud [:smichaud] (Retired)]

It may make a difference that I built from the TB 2.0.0.23 source distro:
ftp://ftp.mozilla.org/pub/mozilla.org/thunderbird/releases/2.0.0.23/source/thunderbird-2.0.0.23-source.tar.bz2

Here's the mozconfig I used:

mk_add_options MOZ_CO_PROJECT=mail
mk_add_options MOZ_MAKE_FLAGS=-j3
mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/obj-thunderbird-official
ac_add_options --enable-application=mail
ac_add_options --disable-debug
ac_add_options --enable-optimize="-O2 -gstabs+"
ac_add_options --enable-official-branding
ac_add_options --disable-tests
ac_add_options --disable-shared
ac_add_options --enable-static
ac_add_options --enable-pango
ac_add_options --enable-default-toolkit=gtk2

I previously used this to build TB 2.0.0.22, and had no problems.

And no, I'm not distributing my builds.  They're just for my own use :-)

Comment 4

[Mark Banner (:standard8)]

Thunderbird 2 series is no longer supported, so we're not going to fix this.