Closed
Bug 51210
Opened 24 years ago
Closed 24 years ago
Inefficiency in the code (patch included)
Categories
(Core :: XPCOM, defect, P3)
Tracking
()
RESOLVED
FIXED
mozilla1.0
People
(Reporter: mstankus, Assigned: kandrot)
Details
(Keywords: perf)
Attachments
(2 files)
428 bytes,
text/plain
|
Details | |
705 bytes,
patch
|
Details | Diff | Splinter Review |
From Bugzilla Helper:
User-Agent: Mozilla/4.75 [en] (X11; U; Linux 2.2.15-4mdk i686)
BuildID: 200009010000
The code computes strlen(demangled) when strlen(demangled)!=0 is issue
Reproducible: Always
Steps to Reproduce:
1. Read code
Actual Results:
Expected Results:
Reporter | ||
Comment 1•24 years ago
|
||
Comment 2•24 years ago
|
||
A correct though minor performance fix - I see no reason not to apply it; it's a
more correct test and is obviously correct.
Severity to trivial, confirming, added 'perf'
Comment 3•24 years ago
|
||
file nsNativeComponentLoader.cpp - smfr said that dp is in charge of that file,
cc'ing him on this.
Comment 5•24 years ago
|
||
We are in approval only fixes. This I dont this will improve performance. This
is in DumpLoadError() a corner case.
Thanks for the patch.
Assignee: dp → rayw
Comment 6•24 years ago
|
||
Marking Future. I wanted to do this before I reassign. Ray hope that is ok.
Target Milestone: --- → Future
Comment 7•24 years ago
|
||
I appreciate the help.
Updated•24 years ago
|
Status: NEW → ASSIGNED
Comment 8•24 years ago
|
||
Edward: Welcome to xpcom!
Status: ASSIGNED → NEW
Component: Browser-General → XPCOM
QA Contact: doronr → rayw
Target Milestone: Future → mozilla1.0
Comment 9•24 years ago
|
||
Once again... attempting to reassign from Ray to Edward.
Assignee: rayw → kandrot
Comment 10•24 years ago
|
||
Hello, can somebody just check in this thing? It is obviously a good thing to do
and without risk. So just get this issue out of the world now.
Assignee | ||
Comment 11•24 years ago
|
||
I will get a=, r=, then check it in. Probably when people return from vacation.
Status: NEW → ASSIGNED
Comment 13•24 years ago
|
||
sr=shaver.
![]() |
||
Comment 14•24 years ago
|
||
![]() |
||
Comment 15•24 years ago
|
||
Comment 16•24 years ago
|
||
Fix checked in, marking fixed.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•