Closed Bug 51210 Opened 24 years ago Closed 24 years ago

Inefficiency in the code (patch included)

Categories

(Core :: XPCOM, defect, P3)

All
Linux
defect

Tracking

()

RESOLVED FIXED
mozilla1.0

People

(Reporter: mstankus, Assigned: kandrot)

Details

(Keywords: perf)

Attachments

(2 files)

From Bugzilla Helper: User-Agent: Mozilla/4.75 [en] (X11; U; Linux 2.2.15-4mdk i686) BuildID: 200009010000 The code computes strlen(demangled) when strlen(demangled)!=0 is issue Reproducible: Always Steps to Reproduce: 1. Read code Actual Results: Expected Results:
A correct though minor performance fix - I see no reason not to apply it; it's a more correct test and is obviously correct. Severity to trivial, confirming, added 'perf'
Severity: normal → trivial
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: perf
file nsNativeComponentLoader.cpp - smfr said that dp is in charge of that file, cc'ing him on this.
reassigning, adding patch keyword.
Assignee: asa → dp
Keywords: patch
We are in approval only fixes. This I dont this will improve performance. This is in DumpLoadError() a corner case. Thanks for the patch.
Assignee: dp → rayw
Marking Future. I wanted to do this before I reassign. Ray hope that is ok.
Target Milestone: --- → Future
I appreciate the help.
Status: NEW → ASSIGNED
Edward: Welcome to xpcom!
Status: ASSIGNED → NEW
Component: Browser-General → XPCOM
QA Contact: doronr → rayw
Target Milestone: Future → mozilla1.0
Once again... attempting to reassign from Ray to Edward.
Assignee: rayw → kandrot
Hello, can somebody just check in this thing? It is obviously a good thing to do and without risk. So just get this issue out of the world now.
I will get a=, r=, then check it in. Probably when people return from vacation.
Status: NEW → ASSIGNED
Has this been checked in? I dont think so.
Keywords: review
sr=shaver.
Fix checked in, marking fixed.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: