Need to Clear Validation cache in maintenance scripts

RESOLVED FIXED in 5.1

Status

defect
RESOLVED FIXED
10 years ago
3 years ago

People

(Reporter: rjwalsh, Assigned: rjwalsh)

Tracking

unspecified
x86
All

Details

(Whiteboard: [patch-5.1])

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

10 years ago
I was digging through the cache today and realized we never do anything to clean it.  We should clear this out, probably once a day or so to make sure that stuff doesn't build up here.
Are you talking about test_results_cache?
Target Milestone: --- → 5.1
(Assignee)

Comment 2

10 years ago
Attachment #396245 - Flags: review?(clouserw)
Comment on attachment 396245 [details] [diff] [review]
Clear out validate-* in NETAPP_STORAGE

1) we should escape NETAPP_STORAGE because you never know what kind of crazy stuff IT puts in there ;)

2) We should capture the output and send it to debug()

3) Why are you using (!-name -prune)?  Can't you just do something like: -name "validate-*"
Attachment #396245 - Flags: review?(clouserw) → review-
(Assignee)

Comment 4

10 years ago
Posted patch v2 (obsolete) — Splinter Review
Attachment #396245 - Attachment is obsolete: true
Attachment #396462 - Flags: review?(clouserw)
Comment on attachment 396462 [details] [diff] [review]
v2

> /dev/null gives us no output
Attachment #396462 - Flags: review?(clouserw) → review-
(Assignee)

Comment 6

10 years ago
Posted patch v3Splinter Review
No /dev/null
Attachment #396462 - Attachment is obsolete: true
Attachment #396517 - Flags: review?(clouserw)
Comment on attachment 396517 [details] [diff] [review]
v3

I'll r+ but this won't work unless shell_exec() is all on the same line so please change that before committing.
Attachment #396517 - Flags: review?(clouserw) → review+
(Assignee)

Updated

10 years ago
Whiteboard: [patch-5.1]
(Assignee)

Comment 8

10 years ago
Fixed in r50386
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.