MMGC_MEMORY_PROFILER needs to use avmfeatures.as

VERIFIED FIXED in flash10.1

Status

defect
P2
normal
VERIFIED FIXED
10 years ago
10 years ago

People

(Reporter: stejohns, Assigned: stejohns)

Tracking

unspecified
flash10.1
Bug Flags:
flashplayer-qrb +
flashplayer-triage +

Details

Attachments

(1 attachment, 2 obsolete attachments)

currently MMGC_MEMORY_PROFILER is hardcoded ON for some platforms, OFF for the rest in MMgc.h. We should move it into the existing config system so that embedders can enable it (or not) in line with everything else.
Assignee: nobody → treilly
Status: NEW → ASSIGNED
Flags: flashplayer-triage+
Flags: flashplayer-qrb+
Priority: -- → P2
Target Milestone: --- → flash10.1
Posted patch Patch (obsolete) — Splinter Review
Assignee: treilly → stejohns
Attachment #396454 - Flags: superreview?(lhansen)
Attachment #396454 - Flags: review?(treilly)
Attachment #396454 - Flags: review?(treilly) → review+
Comment on attachment 396454 [details] [diff] [review]
Patch

VMCFG_MEMORY_PROFILER since MMGC_ names are slated to disappear sooner or later, but I'm not going to insist - we can fix that later.
Attachment #396454 - Flags: superreview?(lhansen)
Attachment #396454 - Flags: superreview+
Attachment #396454 - Flags: review?
Attachment #396454 - Flags: review+
pushed as changeset:   2400:158ddad2728e
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
For some reason it appears that the memory profiler is not being enabled by default on windows.

The code change in shell/avmshell-features.h should turn on the profiler on windows but not ARM, this is the exact same check as before in MMgc/MMgc.h

This is currently causing the "smokes" to fail as there is a memstat test that is not working.
Posted patch patch avmshell-features.h (obsolete) — Splinter Review
change:
AVMPLUS_(MAC|ARM|WIN32) to AVMFEATURE_(MAC|ARM|WIN32)
MMGC_PPC to AVMSYSTEM_PPC
MMGC_64BIT to SIXTYFOURBIT
Attachment #396730 - Flags: review?(stejohns)
Use AVMSYSTEM_64BIT instead of SIXTYFOURBIT which is undef'd
Attachment #396730 - Attachment is obsolete: true
Attachment #396738 - Flags: review?(stejohns)
Attachment #396730 - Flags: review?(stejohns)
Apologies -- bad fix on my part :-/
Comment on attachment 396738 [details] [diff] [review]
patch avmshell-features.h

approved, but I think we prefer

#if FOO (not FOO==1)

and 

#if !FOO (not FOO==0)

as general form...
Attachment #396738 - Flags: review?(stejohns) → review+
Updated patch and pushed as 2405:aefaa59b3743
Attachment #396454 - Attachment is obsolete: true
Attachment #396454 - Flags: review?
Resolved fixed engineering / work item that has been pushed.  Setting status to verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.