512277 - content scrolling itself and anchor link clicks don't cause a redraw (tiles edition)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Pages calling e.g. window.scrollTo will currently mess up panning, I think. We could probably use an onscroll handler (does this work?) to intercept the scroll and turn it into a pan instead, but that might still cause trouble for pages that depend on certain elements being visible in the underlying browser.

Originally fixed by bug 452286, but regressed due to tiles landing.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Can't we let the page scroll too?

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

mainly a backport of the patch for bug 452286

Comment 3

[Roy Frostig :froystig]

Same (but reviewed) patch is in bug 511982 (which is marked as blocking on this one).

Comment 4

[:Gavin Sharp [email: [e-mail]]]

fixed by bug 511982

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

this is sort of working.  Using this attachment (https://bug486133.bugzilla.mozilla.org/attachment.cgi?id=370215) on my nokia n810 with the 20090903 nightly build, it scrolls, but the anchors do not end up at the top, more like at the bottom.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Could you file a new bug about that, please? The general issue is fixed and we won't be backing out that patch, so if there's something weird with that testcase it will require a different fix.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

(nevermind, I filed bug 514623)

Comment 9

[Joel Maher ( :jmaher ) (UTC -8)]

from comment #6, the page doesn't scroll to the top.

Comment 10

[Ben Combee (:bcombee)]

Original issue was fixed, bug in comment #6 was opened in bug 514623.

Comment 11

[Joel Maher ( :jmaher ) (UTC -8)]

thanks Ben.  Verified with 20090908 1.9.2 nightly build on my n810