Created attachment 396251 [details] [diff] [review] proposed fix If you have an html message wrongfully marked as junk and mark it "not junk", it should reload to show the full html instead of the simple html version. Regression from bug 462681. (var isJunk = (junkScore == "") || (junkScore == "0") is wrong.)
Attachment #396251 - Flags: review?(bugzilla)
Comment on attachment 396251 [details] [diff] [review] proposed fix + let wontMoveToJunk = (folder.server.spamSettings.manualMark != + Components.interfaces.nsISpamSettings.MANUAL_MARK_MODE_MOVE) || + folder.isSpecialFolder(Components.interfaces.nsMsgFolderFlags.Junk); This appears to be the wrong sense - I've tested a message on local folders and on pop and when I've disabled the preference to move to the account's junk folder, then wontMoveToJunk is false.
Attachment #396251 - Flags: review?(bugzilla) → review-
This also leads to situations where we get messages half-loaded in the message pane, so I think it would be very good to fix this for TB 3.
Created attachment 398673 [details] [diff] [review] proposed fix, v2 As we're nowadays always moving junk back to inbox, an additional check was needed. (Also i messed up manualMark vs manualMarkMode earlier. Added doc to make it clearer in the future.) The one edge case this doesn't reload where it could be useful is with mark-as-deleted, for the last message in view, but but...
Comment on attachment 398673 [details] [diff] [review] proposed fix, v2 looks good, thx
Attachment #398673 - Flags: review?(bienvenu) → review+
changeset: 3532:310086e2a1d1 http://hg.mozilla.org/comm-central/rev/310086e2a1d1 ->FIXED
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.