Just like it's wrong to inline the current value of minstack. It won't do the right thing in a multi-AvmCore/multi-thread environment. Also note that when minstack=0, the compiled-in stack overflow check is still valid: sp < 0 is false.
Created attachment 396255 [details] [diff] [review] Never compile out the stack overflow check.
Comment on attachment 396255 [details] [diff] [review] Never compile out the stack overflow check. Presumably it was compiled out for speed, but the stated reasoning applies.
Attachment #396255 - Flags: superreview?(lhansen) → superreview+
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Resolved fixed engineering / work item that has been pushed. Setting status to verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.