it's wrong to compile out the stack overflow check when minstack=0

VERIFIED FIXED

Status

Tamarin
Baseline JIT (CodegenLIR)
VERIFIED FIXED
9 years ago
9 years ago

People

(Reporter: Edwin Smith, Assigned: Edwin Smith)

Tracking

(Blocks: 1 bug)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
Just like it's wrong to inline the current value of minstack.  It won't do the right thing in a multi-AvmCore/multi-thread environment.  Also note that when minstack=0, the compiled-in stack overflow check is still valid:  sp < 0 is false.
(Assignee)

Comment 1

9 years ago
Created attachment 396255 [details] [diff] [review]
Never compile out the stack overflow check.
Assignee: nobody → edwsmith
Attachment #396255 - Flags: superreview?(lhansen)
Attachment #396255 - Flags: review?(tharwood)

Updated

9 years ago
Attachment #396255 - Flags: review?(tharwood) → review+

Comment 2

9 years ago
Comment on attachment 396255 [details] [diff] [review]
Never compile out the stack overflow check.

Presumably it was compiled out for speed, but the stated reasoning applies.

Updated

9 years ago
Attachment #396255 - Flags: superreview?(lhansen) → superreview+
(Assignee)

Comment 3

9 years ago
pushed http://hg.mozilla.org/tamarin-redux/rev/d7695b0ec301
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED

Comment 4

9 years ago
Resolved fixed engineering / work item that has been pushed.  Setting status to verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.