512347 - synthesizeDrop from EventUtils doesn't work

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Nochum Sossonko [:Natch]]

It throws since it doesn't specify enough arguments.

Error: uncaught exception: [Exception... "Not enough arguments [nsIDOMDragEvent.initDragEvent]" nsresult: "0x80570001 (NS_ERROR_XPC_NOT_ENOUGH_ARGS)" location: "JS frame :: chrome://mochikit/content/tests/SimpleTest/EventUtils.js :: synthesizeDrop :: line 505" data: no]

The code I was using:

let data = [[ "text/uri-list: http://example.org" ],
            [ "text/plain: http://example.org" ]];

dragDropButtons.forEach(function(val) {
  let button = document.getElementById(val);
  // This throws now, which is why I've commented it out. When synthesizeDrop
  // is fixed this should work just fine. - Natch
   let effectReturned = EventUtils.synthesizeDrop(button, data, "link");
  is(effectReturned, "link" || "copyLink",
     "Wrong dropEffect returned by button: " + val);
})

Comment 1

[Nochum Sossonko [:Natch]]

Attachment: patch

Comment 2

[Nochum Sossonko [:Natch]]

Attachment: patch [Checkin: Comment 10 & 12]

Whoops, patches got merged.

Comment 3

[Nochum Sossonko [:Natch]]

Comment on attachment 396315 [details] [diff] [review]
patch
[Checkin: Comment 10 & 12]

I'm going to try to make this function more useful, currently command handlers are called when this function runs which doesn't work out well when testing elements that have both command handlers and drag handlers.

Comment 4

[Nochum Sossonko [:Natch]]

Attachment: wip 1

This function doesn't really work, the returned dropEffect never matches what actually happens. Another problem is that DragEvents don't set the drag session, so in my case the function fails with an error...

Any help here would be appreciated.

Comment 5

[Nochum Sossonko [:Natch]]

->Default owner, this is getting too complicated for me. The above patch *can* be taken, but I've yet to see a correct dropEffect returned from the function. It used to set the dropEffect, then return that, which doesn't sound all that useful to me...

Comment 6

[Nochum Sossonko [:Natch]]

Comment on attachment 396315 [details] [diff] [review]
patch
[Checkin: Comment 10 & 12]

This at least gets in not to throw, so should be taken.

Comment 7

[Nochum Sossonko [:Natch]]

Maybe once bug 448602 lands, these two functions can just create a pseudo transfer and event object, then call all the event listeners in order and return that? Is that a better hack than the one currently in place?

Comment 8

[Serge Gautherie (:sgautherie)]

Don't this need to land in m-c first?

Comment 9

[Nochum Sossonko [:Natch]]

yes, only this can probably land together, there are no tests that use this function now (they would've failed), and this just makes the method call not throw.

Comment 10

[Serge Gautherie (:sgautherie)]

Comment on attachment 396315 [details] [diff] [review]
patch
[Checkin: Comment 10 & 12]


http://hg.mozilla.org/mozilla-central/rev/8384b031de64

Comment 11

[Nochum Sossonko [:Natch]]

-> Resolved Fixed

Opened bug 514451 to simplify this method somewhat.

Comment 12

[Serge Gautherie (:sgautherie)]

Comment on attachment 396315 [details] [diff] [review]
patch
[Checkin: Comment 10 & 12]


http://hg.mozilla.org/releases/mozilla-1.9.2/rev/b51ae20ae663