512382 - Don't encode test metadata in trace-test subdirectory names

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

There should be a magic comment in the test file instead, like a mode line.  The test runner would have to sniff it, which is a little painful.

Comment 1

[Nicholas Nethercote [inactive]]

Another possibility is to have a file alongside, eg. "foo.test_details" (or whatever suffix you like) describes how to run "foo.js".  In this case, making the file optional is probably a good idea as many tests won't need any extra info.  We use a system like this with the Valgrind regtests (albeit the files are non-optional) and it works well.

Comment 2

[David Mandelin [:dmandelin]]

Attachment: Patch

For now, I went with the modeline idea. It will be easy to change to separate control files if that turns out to have a significant advantage later.

There is no measurable perf cost to reading the control lines.

Comment 3

[Jason Orendorff [:jorendorff]]

Comment on attachment 396530 [details] [diff] [review]
Patch

Great!

>+    @classmethod
>+    def from_file(self, path):

Since it's a classmethod, cls instead of self...

>+        return Test(path, slow, allow_oom)

and cls instead of Test here.

Comment 4

[David Mandelin [:dmandelin]]

Pushed to TM as 33d73ef9b5d5.

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

http://hg.mozilla.org/mozilla-central/rev/33d73ef9b5d5 (fixed, I think, dmandelin, please reopen if not)

Comment 6

[Robert Sayre]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/649c56156aa5