512386 - [ForumUX] Admin panel for new "Ask a question" form

Status: VERIFIED FIXED

(support.mozilla.org :: Forum, task, P1)

Description

[Paul Craciunoiu [:paulc]]

This is for the admin panel in bug 505425. Basically, that bug will provide a fixed form, and this will add a UI for customizing that form. We should investigate the degree of customization that we want before I go ahead and implement this.

From a discussion with Cheng, the basics involve:
* Control over # and text of questions in step 1 (radio buttons filtering what type of problem user is having)
* Control over # and text of fields in last step
* Correlation between first and last step (which fields show up for which radio button/choice)

Anything else?

Comment 1

[James Socol [:jsocol, :james]]

Attachment: patch, v1, adding 5 files

Adds 5 files:
* tiki-admin_ask_a_question.php - The actual admin panel, handles form submissions.
  - templates/tiki-admin_ask_a_question.tpl - the primary view
  - templates/tiki-admin_ask_a_question-section.tpl - detailed view for a section
  - templates/tiki-admin_ask_a_question-field.tpl - detailed view for a field
* tiki-js-ask_a_question.php - Generates JavaScript to hand this configuration to the form.

Comment 2

[James Socol [:jsocol, :james]]

Attachment: table structure

Comment 3

[Paul Craciunoiu [:paulc]]

Comment on attachment 399639 [details] [diff] [review]
patch, v1, adding 5 files

Oops. I don't see a questionlib.php file in this patch?

Comment 4

[James Socol [:jsocol, :james]]

Attachment: patch, v2

As Paul pointed out, there should actually be _six_ files.

Comment 5

[Paul Craciunoiu [:paulc]]

Comment on attachment 399943 [details] [diff] [review]
patch, v2

Some broken things:
* Adding new field doesn't save values for "Value" and "Weight"
* Editing field doesn't save values for "Value"
* Listing fields for a section (option) lists the value of "Weight" under the "Value" column (the actual "Value" should be listed)
* Can you order fields with same weight by name?

The rest looks great though :)

Comment 6

[James Socol [:jsocol, :james]]

Attachment: patch, v3

* Fixed
* Fixed
* Fixed
* Wontfix

Comment 7

[James Socol [:jsocol, :james]]

Attachment: table structure, v2

Comment 8

[Paul Craciunoiu [:paulc]]

Comment on attachment 400107 [details] [diff] [review]
patch, v3

Looks good.

Comment 9

[James Socol [:jsocol, :james]]

r51329 / r51331

Comment 10

[Paul Craciunoiu [:paulc]]

Woot!!

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

Does this need SQL to be run?

https://support-stage.mozilla.org/tiki-admin_ask_a_question.php gives me:

Context:
File	tiki-admin_ask_a_question.php
Url	tiki-admin_ask_a_question.php
Query:
SELECT id FROM tiki_question_sections ORDER BY weight;
Values:
Message:
Table 'support_wiki.tiki_question_sections' doesn't exist
Built query was probably:
SELECT id FROM tiki_question_sections ORDER BY weight;

Comment 12

[[:Cww]]

yeah.  We'll need to add the tables.

Comment 13

[[:Cww]]

that's https://bugzilla.mozilla.org/attachment.cgi?id=400108

Comment 14

[Stephen Donner [:stephend] Not actively reading bugmail]

When SQL needs to be run before QA can verify, please add a dependency (depends on bug xxx); thanks!

Comment 15

[Vishal Kamdar [:vish_moz]]

when editing a field on this page https://support-stage.mozilla.org/tiki-admin_ask_a_question.php, if you put a new value for weight and hit 'Save Changes' , it does not save the new value. The old value sticks.

Comment 16

[James Socol [:jsocol, :james]]

Attachment: patch to patch 3

Fixes the error discovered in comment 15.

Comment 17

[Michael Morgan [:morgamic]]

Comment on attachment 401356 [details] [diff] [review]
patch to patch 3

Not sure why 10 is hard-coded as a default weight.  Might make sense to have a default in a constants file somewhere and use that instead.  That said, rest looks good.

Comment 18

[Vishal Kamdar [:vish_moz]]

Verified, FIXED.