If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Status

Webtools Graveyard
Cesium
RESOLVED WONTFIX
8 years ago
a year ago

People

(Reporter: jbalogh, Assigned: jbalogh)

Tracking

Details

Attachments

(3 attachments)

(Assignee)

Description

8 years ago
As I find things that offend my delicate sensibilities, I'll post them here for rdoherty to review so he's aware and understanding of the changes.
(Assignee)

Comment 1

8 years ago
Created attachment 396380 [details] [diff] [review]
refactoring settings.py, separating into required vs. suggested overrides

Moving more things that really should be overridden to the top, giving defaults for TEMPLATE_DIRS and MEDIA_ROOT.
Attachment #396380 - Flags: review?(rdoherty)
(Assignee)

Comment 2

8 years ago
Created attachment 396381 [details] [diff] [review]
no hardcoding MEDIA_URL

I think site_media looks clunky, so I'd like to change it.  But oh no, it's hardcoded everywhere!

We'll need to have Shyam update local_settings.py on staging once this one goes in.
Attachment #396381 - Flags: review?(rdoherty)
Attachment #396381 - Flags: review?(rdoherty) → review+
Attachment #396380 - Flags: review?(rdoherty) → review+
(Assignee)

Comment 3

8 years ago
Thanks, r50078 for settings and r50079 for MEDIA_URL.
(Assignee)

Comment 4

8 years ago
Created attachment 399914 [details]
oh my

Moving all the user junk out of autoyslow, lots of tests (4 fail on purpose because the pages are broken), using nice names for views.

http://github.com/jbalogh/cesium/tree/refactor
Attachment #399914 - Flags: review?(rdoherty)
Attachment #399914 - Flags: review?(rdoherty) → review+
Comment on attachment 399914 [details]
oh my

refactory rampage review complete!
(Assignee)

Updated

7 years ago
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → WONTFIX
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.