Closed Bug 512402 Opened 12 years ago Closed 12 years ago

Auto-select of URLBar is broken

Categories

(Firefox for Android Graveyard :: General, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: mfinkle, Assigned: mfinkle)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
The toolbar locking patch in bug 511123 added code to lock/unlock the toolbar using fixed positioning. We were already using the fixed positioning method, but now we were calling it whenever certain dialogs were displayed.

One of those dialogs is the awesomebar panel. We select all the text in the URL edit box when opening the awesomebar, however the fixed positioning code is causing the edit box to unselect all the text (after a brief moment when all the text appears selected).

To fix this, the patch moves the pushDialog() and edit.select() around a little bit.
Attachment #396384 - Flags: review?(gavin.sharp)
Attachment #396384 - Flags: review?(gavin.sharp) → review+
pushed: https://hg.mozilla.org/mobile-browser/rev/eb948fb09849
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
verified fixed in 20091001 1.9.2 b4 on my n810
Status: RESOLVED → VERIFIED
bugspam
Assignee: nobody → mark.finkle
You need to log in before you can comment on or make changes to this bug.