Closed Bug 512409 Opened 12 years ago Closed 12 years ago

nanojit support for Windows x64

Categories

(Core :: JavaScript Engine, defect)

x86_64
Windows Vista
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: m_kato, Assigned: m_kato)

References

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file, 2 obsolete files)

Attached patch WIP v0.1 (obsolete) — Splinter Review
You know, x86_64 backend of nanojit was removed at past month.  By bug 511919, although x86_64 backend into redux's code will be copied to tracemonkey tree, this is still broken.
Cool! Graydon landed the NativeX64.h/.cpp files a few days ago so you can probably cut the patch size down a little :)

Getting it to work is still blocked on a little more merge progress (it has come a long way but a few headers are still in flux), and the tracer needs changes to the demotion logic to be compatible with 64-bit systems. Once the dust has started to clear we'll probably need a new LIR_float opcode to differentiate from LIR_quad.
Blocks: 489146
Attached patch WIP v0.2 (obsolete) — Splinter Review
Assignee: general → m_kato
Attachment #396389 - Attachment is obsolete: true
Depends on: 515545
Attached patch patch v1Splinter Review
Attachment #397238 - Attachment is obsolete: true
Comment on attachment 402547 [details] [diff] [review]
patch v1

We will support 2 compiler (VC++ or GCC) for x64 Windows.  So, we have to use correct defines.
Attachment #402547 - Flags: review?(dvander)
Attachment #402547 - Flags: review?(dvander) → review+
As it checked in shouldn't this be RESOLVED FIXED?
(In reply to comment #6)
> As it checked in shouldn't this be RESOLVED FIXED?

When it lands on mozilla-central. Right now we're using the status whiteboard to denote tracemonkey landings.
http://hg.mozilla.org/mozilla-central/rev/54bc1f6a31ef
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.