512506 - Mozmill test for verifying breakpad is installed

Status: VERIFIED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This Mozmill test will test if Breakpad is installed and enabled per default.

Litmus tests:
https://litmus.mozilla.org/show_test.cgi?id=5910
https://litmus.mozilla.org/show_test.cgi?id=7953

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Patch v1 (trunk)

That's the version for >=1.9.2 where we can use the nsICrashReporter interface. For 1.9.1 I have to implement an ini parser.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 396479 [details] [diff] [review]
Patch v1 (trunk)

Needs an update.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Patch v1 (1.9.1)

That test is for 1.9.1 and uses the ini parser to get the state of the crash reporter.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Patch v2 (trunk)

This updated test for trunk checks also for the existence of the crash reporter application. I wasn't able to detect if it is already done by the interface itself. But that would make it double safe.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Aakash: ping?

Comment 6

[Aakash Desai [:aakashd]]

Comment on attachment 396520 [details] [diff] [review]
Patch v2 (trunk)

This test hangs on a command line run for OSX (didn't run on XP via commandline). I ran this via IDE on XP and OSX and they both run and pass fine. The logic is correct, so once you can make sense of the hang on OSX, then I'll r+ this.

Comment 7

[Aakash Desai [:aakashd]]

Comment on attachment 396515 [details] [diff] [review]
Patch v1 (1.9.1)

A run on IDe and Command Line passes on both XP and OSX. The logic and comments are all correct, so r+.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The test works well for me with Shiretoko, Namoroka, and Minefield via IDE and command line. Can you please check again with the latest Mozmill 1.2.1 release build? Otherwise we could go ahead and check it in so other people could test too.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Aakash, can you please run the test from the command line and throw the value of execFile.exists() right before the assertJS test? Run Mozmill with the --showall option.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Anthony, could you please have a look at the trunk patch and if you have problems too? Thanks.

Comment 11

[u279076]

AFAICT the code is well-formed.  The test fails on line 82:   controller.assertJS(crashReporter.enabled == states["Enabled"]);

fail :: javascript assert was not succesful

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Anthony and Aakash, can you both please evaluate the following string inside the Error Console? Which output do you see in the message pane? I get a 'true'.

Components.classes["@mozilla.org/toolkit/crash-reporter;1"].getService(Components.interfaces.nsICrashReporter).enabled;

Comment 13

[u279076]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2

Warning: reference to undefined property Components.classes['@mozilla.org/toolkit/crash-reporter;1'].getService(Components.interfaces.nsICrashReporter).enabled
Source File: javascript:%20Components.classes["@mozilla.org/toolkit/crash-reporter;1"].getService(Components.interfaces.nsICrashReporter).enabled;
Line: 1

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a2pre) Gecko/20090826 Namoroka/3.6a2pre

TRUE

Comment 14

[(not currently active) Ted Mielczarek]

Note that the crashreporter will only be enabled on nightly/release builds, not on self builds.

Also, that nsICrashReporter.enabled is not available on 1.9.1.

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 396520 [details] [diff] [review]
Patch v2 (trunk)

Aakash, have you used a debug build for your tests? Then it would explain why the test has always been failed for Minefield on your box. I haven't thought about that little but meaningful difference. Please check with a nightly build again.

Comment 16

[Aakash Desai [:aakashd]]

Comment on attachment 396520 [details] [diff] [review]
Patch v2 (trunk)

I never used a debug build to run against your testcase (and haven't run trunk nightlies in general for awhile now) and neither did Anthony as he doesn't build his own debug builds anyways.

Comment 17

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Aakash, I have asked you to repeat the test. It means that I also want to get the output from the command I asked for in comment 12. Please comment here with the results for Namoroka and Minefield.

Comment 18

[Aakash Desai [:aakashd]]

I did a run on Namoroka and Minefield via IDE and the testscript passed on OSX and XP. It still hangs on command line and there are still no errors or any messages showing on console.

Comment 19

[u279076]

Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.3a1pre) Gecko/20090901 Minefield/3.7a1pre

Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2a2pre) Gecko/20090901 Namoroka/3.6a2pre

RESULT: Fail -> Error: Cc['@mozilla.org/toolkit/crash-reporter;1'] is undefined
Source File: file:///home/ashughes/.mozilla/firefox/r47jio9b.namo/extensions/[e-mail]/resource/modules/frame.js -> file:///home/ashughes/mozmill-tests/firefox/testInstallation/testBreakpadInstalled.js
Line: 64

NOTE: I see this result with both builds via IDE and command line.  At no point does the test hang.

Comment 20

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #19)
> Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.3a1pre) Gecko/20090901
> Minefield/3.7a1pre
> 
> RESULT: Fail -> Error: Cc['@mozilla.org/toolkit/crash-reporter;1'] is undefined

That should be expected too because Breakpad isn't available in 64bit builds. Anthony, once you are in the office it would be great when you can test it on a Mac. Thanks so far.

Comment 21

[u279076]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.3a1pre) Gecko/20090902 Minefield/3.7a1pre

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a2pre) Gecko/20090902 Namoroka/3.6a2pre

Both builds PASS via command line.

Comment 22

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Thanks Anthony. Good to know that it works for you. Probably something is messy in Aakash's setup of Mozmill.

Aakash, I would propose to checkin the test. If we get failures over time I have to update it. But having it in the tree we get more results on it. Are you ok with that?

Comment 23

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 396520 [details] [diff] [review]
Patch v2 (trunk)

After talking on IRC and given the result from Anthony we will checkin the test and watch the results the next days.

Comment 24

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/ec08f4333f57
http://hg.mozilla.org/qa/mozmill-tests/rev/0d825130b3a4

Comment 25

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Mass move of Mozmill Test related project bugs to newly created components. You can filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.