If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Ship a JSON representation of default search plugins

RESOLVED WONTFIX

Status

()

Firefox
Search
P3
normal
RESOLVED WONTFIX
8 years ago
2 years ago

People

(Reporter: rflint, Unassigned)

Tracking

(Blocks: 1 bug, {perf})

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [ts])

Doing so could save us a bit of time on first startup and after updates. We'll need to:
- Add support for loading engines from file path agnostic JSON files
- Figure out what to do about localized plugins (convert to JSON at build time?)

This isn't a top priority because we already cache these plugins after the first startup, but it's something to keep in mind as we look for more cold-start areas to improve.
Whiteboard: [ts]

Comment 1

8 years ago
I'm not sure if we should move to something completely different, if we're making a change that drastic. AKA something that's not separate files.

There has been talk about what we'd need for a multi-locale package, which would want the plugins to go in and out of the app based on locale selection, too.
Another advantage of "something completely different", as Axel's put it, might be an ability to easily remove default search engines. This is now rather a complicated thing to do (b/c we have to remove from the profile).
(In reply to comment #1)
> I'm not sure if we should move to something completely different, if we're
> making a change that drastic. AKA something that's not separate files.

We're talking about shipping a single JSON file that includes all default plugins.

(In reply to comment #2)
> Another advantage of "something completely different", as Axel's put it, might
> be an ability to easily remove default search engines. This is now rather a
> complicated thing to do (b/c we have to remove from the profile).

I don't understand how this is relevant at all. We don't store defaults in the profile, unless you're talking about the cache, which we invalidate when needed (i.e. explicitly on update, and when we detect file changes to the appdir, etc.).
only affects first run post install or update, so setting low priority.
Priority: -- → P3
Blocks: 447581
I don't think the time we spend to parse the default search plugins affects the first startup much, especially now that the files are all inside omni.ja (since bug 1162569).
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.