512599 - Add MOTD to editor tools

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect, P2)

Description

[Nick Nguyen [:osunick]]

We need the ability to set a message that appears at the top of every review screen that can be set by an administrator.  This message would contain information like 

"Be on the lookout for add-ons which change search preferences, for more info read our wiki."

Only admins and senior editors can change this message from the admin tools, and we need the ability to put links in this message.

This should be placed above the title bar that starts with "Review <add-on name" in bold text.

Comment 1

[Alex Buchanan [:abuchanan]]

Attachment: patch v1

Comment 2

[Ryan Doherty (:rdoherty)]

Comment on attachment 400817 [details] [diff] [review]
patch v1

Looks good!

Comment 3

[Ryan Doherty (:rdoherty)]

Comment on attachment 400817 [details] [diff] [review]
patch v1

Small note: a blank line between motd(), _set_motd() and _get_motd() would be nice :)

Comment 4

[Alex Buchanan [:abuchanan]]

patch committed,

ending        app/controllers/editors_controller.php
Adding         app/views/editors/motd_admin.thtml
Sending        app/views/editors/review.thtml
Sending        app/views/elements/developers/editorsmenu.thtml
Adding         app/views/elements/developers/review_motd.thtml
Sending        app/webroot/css/editors.css

The rule "Admin:EditorsMOTD" needs to be added to the Senior Editor group when deployed.  I've added this on preview.

The MOTD can be edited at,
https://preview.addons.mozilla.org/en-US/editors/motd

(In reply to comment #3)
> (From update of attachment 400817 [details] [diff] [review])
> Small note: a blank line between motd(), _set_motd() and _get_motd() would be
> nice :)

done

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://preview.addons.mozilla.org/en-US/editors/motd -- I didn't test for RTL.  Ehsan, is this OK in RTL?

Comment 6

[(no longer active)]

(In reply to comment #5)
> Verified FIXED on https://preview.addons.mozilla.org/en-US/editors/motd -- I
> didn't test for RTL.  Ehsan, is this OK in RTL?

Can you please attach screenshots?  I don't have access to the editors panel in my account on preview.a.m.o.

Comment 7

[Alex Buchanan [:abuchanan]]

Attachment: RTL screenshot 1

Comment 8

[Alex Buchanan [:abuchanan]]

Attachment: RTL screenshot 2

Comment 9

[(no longer active)]

Comment on attachment 401050 [details]
RTL screenshot 2

The first screenshot looks correct.

This one, however, seems to have problems.  It would be great if you can attach an en-US screenshot of the same page so that I can compare them exactly.

Comment 10

[Alex Buchanan [:abuchanan]]

Attachment: screenshot, english

Comment 11

[Alex Buchanan [:abuchanan]]

keep in mind, the only change to the review page (i.e. screenshots 2 & 3) is the blue box at the top.  Any other RTL issues are most likely a existing issue -> separate bug.

Also, if it would be helpful, I think we could grant you the Senior Editor role on preview, for testing.  Clouserw, is that ok?  (note, the DB refreshes every day, so you'll lose this role when it does)

Thanks!

Comment 12

[Wil Clouser [:clouserw]]

The preview database hasn't refreshed in months.  I added Ehsan as a senior editor.

Comment 13

[(no longer active)]

(In reply to comment #11)
> keep in mind, the only change to the review page (i.e. screenshots 2 & 3) is
> the blue box at the top.  Any other RTL issues are most likely a existing issue
> -> separate bug.

Oh, the blue bar is fine.  I'll file another bug for the rest of the issues.

Comment 14

[(no longer active)]

(In reply to comment #13)
> (In reply to comment #11)
> > keep in mind, the only change to the review page (i.e. screenshots 2 & 3) is
> > the blue box at the top.  Any other RTL issues are most likely a existing issue
> > -> separate bug.
> 
> Oh, the blue bar is fine.  I'll file another bug for the rest of the issues.

Filed bug 518156.