Closed Bug 512603 Opened 10 years ago Closed 10 years ago

The <switch> in full-struct-cond-02-t.html is failing

Categories

(Core :: SVG, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
Tracking Status
status1.9.2 --- beta1-fixed

People

(Reporter: jwatt, Assigned: longsonr)

References

()

Details

(Keywords: regression)

Attachments

(1 file)

The <switch> in full-struct-cond-02-t.html is failing
Keywords: regression
Attached patch patchSplinter Review
adopting string clears the string it is being assigned from so we lose the bsae system language attribute after the first element child.
Assignee: nobody → longsonr
Attachment #399113 - Flags: review?(jwatt)
Flags: blocking1.9.2?
Flags: blocking1.9.2? → wanted1.9.2+
Attachment #399113 - Flags: review?(jwatt) → review+
Comment on attachment 399113 [details] [diff] [review]
patch

r=jwatt, but please use nsAutoString to avoid unnecessary heap allocations.
Comment on attachment 399113 [details] [diff] [review]
patch

We really should land this on branch.
Attachment #399113 - Flags: approval1.9.2?
Comment on attachment 399113 [details] [diff] [review]
patch

roc, jwatt would like you to take a look at this. I don't think that changing this patch to nsAutoString is appropriate and jwatt says that string classes make his head hurt.
Attachment #399113 - Flags: superreview?(roc)
Attachment #399113 - Flags: superreview?(roc) → superreview+
pushed http://hg.mozilla.org/mozilla-central/rev/4f08fbb3a8d3
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Attachment #399113 - Flags: approval1.9.2? → approval1.9.2+
You need to log in before you can comment on or make changes to this bug.