512616 - "collapse/expand comment" removes css-class 'bz_comment_text'.

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[nayuta]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2 (.NET CLR 3.5.30729)
Build Identifier: 3.4.1

When I click [-], the collapse_comment function defined in 
template/en/default/bug/comments.html.tmpl 
sets the css-class of a comment element to 'collapsed'.
A css-class 'bz_comment_text' is removed.

It should be 'bz_comment_text collapsed'.

Then, when I click [+], the expand_comment function defined in 
template/en/default/bug/comments.html.tmpl 
sets the css-class of a comment element to empty.

It should be 'bz_comment_text'.


Reproducible: Always

Comment 1

[nayuta]

Attachment: dont remove 'bz_comment_text'

Comment 2

[Frédéric Buclin]

Comment on attachment 396643 [details] [diff] [review]
dont remove 'bz_comment_text'

Asking our YUI guru. :)

Comment 3

[Frédéric Buclin]

I can confirm that the class is gone.

Comment 4

[nayuta]

Now, this bug is assigned to me.
What should I do next ?

Comment 5

[Frédéric Buclin]

(In reply to comment #4)
> What should I do next ?

For now, nothing. Wait for pyrzak to review your patch. If your patch gets review-, you will have to update it. If it gets review+, one of the managers will approve it and commit it into CVS.

Comment 6

[Guy Pyrzak]

Comment on attachment 396643 [details] [diff] [review]
dont remove 'bz_comment_text'

Looks good.

Comment 7

[Frédéric Buclin]

tip:

Checking in template/en/default/bug/comments.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/comments.html.tmpl,v  <--  comments.html.tmpl
new revision: 1.42; previous revision: 1.41
done

3.4.1:

Checking in template/en/default/bug/comments.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/comments.html.tmpl,v  <--  comments.html.tmpl
new revision: 1.41.2.1; previous revision: 1.41
done