512712 - Upgrade mozilla-central and tryserver to use GCC 4.3.3

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Benjamin Smedberg]

Upgrade mozilla-central and tryserver to use GCC 4.3.3

Comment 1

[Benjamin Smedberg]

Attachment: Use GCC 4.3.3 on Linux mozilla-central, rev. 1

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 396741 [details] [diff] [review]
Use GCC 4.3.3 on Linux mozilla-central, rev. 1

We've been using symlinks to try to minimize the actual number of mozconfigs to maintain, eg

mozilla2/linux:
electrolysis@ -> mozilla-central
places@ -> mozilla-central
tracemonkey@ -> mozilla-central

mozilla2/linux/mozilla-1.9.2:
codecoverage@ -> ../mozilla-central/codecoverage
debug@ -> ../mozilla-central/debug
nightly@ -> ../mozilla-central/nightly
release/
unittest@ -> ../mozilla-central/unittest
xulrunner@ -> ../mozilla-central/xulrunner

so this patch will affect much more than just mozilla-central. Maybe it's intended that the project branches come along for the ride, but mozilla-1.9.1 & 1.9.2 will need the symlinks broken. Bonus points if you can preserve history while doing that.

Comment 3

[Benjamin Smedberg]

Attachment: Break the symlinks from -1.9.1, -1.9.2 and linux64, rev. 1

This breaks the necessary symlinks so that linux64, -1.9.1 and -1.9.2 are not modified with the other patch. The project branches which track m-c (electrolysis/places/tracemonkey) are still symlinked.

Comment 4

[Benjamin Smedberg]

Comment on attachment 396741 [details] [diff] [review]
Use GCC 4.3.3 on Linux mozilla-central, rev. 1

After the symlink-breaking patch I believe this one is still correct.

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

(In reply to comment #3)
> Created an attachment (id=397663) [details]
> Break the symlinks from -1.9.1, -1.9.2 and linux64, rev. 1

Could you publish a repo with these changes somewhere ? hg import is complaining about
abort: path 'mozilla2-staging/linux/mozilla-1.9.1/debug/mozconfig' traverses symbolic link 'mozilla2-staging/linux/mozilla-1.9.1/debug'

Comment 6

[Benjamin Smedberg]

Attachment: hg bundle with both patches

Here's a bundle you can use to import the patches locally: do hg unbundle <filename> in a buildbot-configs tree

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 397663 [details] [diff] [review]
Break the symlinks from -1.9.1, -1.9.2 and linux64, rev. 1

Thanks for the bundle, it looks fine to me, r+.  I did wonder why Linux64 isn't included here, and noticed there isn't currently a column for that on the Electrolysis tree. Would you like one ? It's currently using gcc 4.2.3. We can followup rather than block but it'd be good to keep all the linux builds on a branch in sync.

Comment 8

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 396741 [details] [diff] [review]
Use GCC 4.3.3 on Linux mozilla-central, rev. 1

r+. I'm concerned that the try server change affects all branches but lets assume the vast majority of try builds are m-c (or m-c derived) and revisit later if that's not true.

Also, code coverage is the only m-c build left on gcc 4.1. Do you know of any contact with Murali about updating that too ? I'm guessing it's better to keep all the builds for a branch on the same compiler, rather than all the code coverage builds together.

Let us know if you need any pointers on using the clobberer.

Comment 9

[Benjamin Smedberg]

http://hg.mozilla.org/build/buildbot-configs/rev/8674359326dc
http://hg.mozilla.org/build/buildbot-configs/rev/9cf2150ab245

I'll file followups for code coverage... the code-coverage builds use a standard compiler?

Comment 10

[Benjamin Smedberg]

I don't think the tryserver config really matters: branch compiles with GCC 4.3 just fine, it's only that we're not using it in production.