Closed Bug 512712 Opened 13 years ago Closed 13 years ago
Upgrade mozilla-central and tryserver to use GCC 4
8.69 KB, patch
|Details | Diff | Splinter Review|
14.22 KB, patch
|Details | Diff | Splinter Review|
7.50 KB, application/octet-stream
Upgrade mozilla-central and tryserver to use GCC 4.3.3
Attachment #396741 - Flags: review?(ted.mielczarek) → review+
Comment on attachment 396741 [details] [diff] [review] Use GCC 4.3.3 on Linux mozilla-central, rev. 1 We've been using symlinks to try to minimize the actual number of mozconfigs to maintain, eg mozilla2/linux: electrolysis@ -> mozilla-central places@ -> mozilla-central tracemonkey@ -> mozilla-central mozilla2/linux/mozilla-1.9.2: codecoverage@ -> ../mozilla-central/codecoverage debug@ -> ../mozilla-central/debug nightly@ -> ../mozilla-central/nightly release/ unittest@ -> ../mozilla-central/unittest xulrunner@ -> ../mozilla-central/xulrunner so this patch will affect much more than just mozilla-central. Maybe it's intended that the project branches come along for the ride, but mozilla-1.9.1 & 1.9.2 will need the symlinks broken. Bonus points if you can preserve history while doing that.
Attachment #396741 - Flags: review?(bhearsum) → review-
This breaks the necessary symlinks so that linux64, -1.9.1 and -1.9.2 are not modified with the other patch. The project branches which track m-c (electrolysis/places/tracemonkey) are still symlinked.
Attachment #397663 - Flags: review?
Attachment #397663 - Flags: review? → review?(nthomas)
Comment on attachment 396741 [details] [diff] [review] Use GCC 4.3.3 on Linux mozilla-central, rev. 1 After the symlink-breaking patch I believe this one is still correct.
Attachment #396741 - Flags: review- → review?(nthomas)
(In reply to comment #3) > Created an attachment (id=397663) [details] > Break the symlinks from -1.9.1, -1.9.2 and linux64, rev. 1 Could you publish a repo with these changes somewhere ? hg import is complaining about abort: path 'mozilla2-staging/linux/mozilla-1.9.1/debug/mozconfig' traverses symbolic link 'mozilla2-staging/linux/mozilla-1.9.1/debug'
Here's a bundle you can use to import the patches locally: do hg unbundle <filename> in a buildbot-configs tree
Attachment #397663 - Flags: review?(nthomas) → review+
Comment on attachment 397663 [details] [diff] [review] Break the symlinks from -1.9.1, -1.9.2 and linux64, rev. 1 Thanks for the bundle, it looks fine to me, r+. I did wonder why Linux64 isn't included here, and noticed there isn't currently a column for that on the Electrolysis tree. Would you like one ? It's currently using gcc 4.2.3. We can followup rather than block but it'd be good to keep all the linux builds on a branch in sync.
Attachment #396741 - Flags: review?(nthomas) → review+
Comment on attachment 396741 [details] [diff] [review] Use GCC 4.3.3 on Linux mozilla-central, rev. 1 r+. I'm concerned that the try server change affects all branches but lets assume the vast majority of try builds are m-c (or m-c derived) and revisit later if that's not true. Also, code coverage is the only m-c build left on gcc 4.1. Do you know of any contact with Murali about updating that too ? I'm guessing it's better to keep all the builds for a branch on the same compiler, rather than all the code coverage builds together. Let us know if you need any pointers on using the clobberer.
http://hg.mozilla.org/build/buildbot-configs/rev/8674359326dc http://hg.mozilla.org/build/buildbot-configs/rev/9cf2150ab245 I'll file followups for code coverage... the code-coverage builds use a standard compiler?
I don't think the tryserver config really matters: branch compiles with GCC 4.3 just fine, it's only that we're not using it in production.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.