Closed Bug 512723 Opened 15 years ago Closed 15 years ago

collection voting js should only be included once

Categories

(addons.mozilla.org Graveyard :: Collections, defect)

Product:
addons.mozilla.org Graveyard
Component:
Collections
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: jbalogh, Assigned: jbalogh)

Details

Attachments

(1 file)

check it!
4.06 KB, patch
rdoherty
: review+
Details | Diff | Splinter Review 
Binding the same handler 8 times leads to 8 POSTs.  Just 1 POST is preferred.
Attached patch check it! — — Splinter Review 

        Attachment #396760 -
        Flags: review?(rdoherty)

    
    

    
  
Comment on attachment 396760 [details] [diff] [review]
check it!

Works. Should be a  module in addons.js though, but since it's small I'll live.

        Attachment #396760 -
        Flags: review?(rdoherty) → review+

    
    

    
  
r50190, thanks.  I moved it co collections.js and everything is glorious.

QA: make sure you shift+reload to refresh js.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED

    
    

    
  
Verified FIXED; I just regression-tested with Firefox 3.5 and IE 7/8.
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: