Closed Bug 512777 Opened 11 years ago Closed 8 years ago

Refactor nsNavHistory.cpp into more manageable pieces

Categories

(Toolkit :: Places, defect)

defect
Not set
normal

Tracking

()

RESOLVED INCOMPLETE

People

(Reporter: cbartley, Unassigned)

Details

sdwilsh: nsNavHistory is like Places' nsDocShell.

I'm pretty sure he didn't mean that in a good way.

Seriously, it's over 8000 lines of code now, which is pretty unwieldy.

I'm proposing that we simply break it out into multiple component files for now, and not worry about the actual architecture.

You wouldn't necessarily need a file for each implemented interface (especially if they're small), but breaking them out into three or four groups of interfaces with each group in a separate file might make the code more approachable.

This could make the code easier to understand with a relatively small amount of effort, and it might make a later true architectural refactoring easier to do.
should be rewritten in js before we ever spend the time to do this.
We certainly can do it iteratively though as we add/change interfaces we implement.
sure we will do this iteratively (and we already did for some parts), we don't need a tracking bug though.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.