FindNext always receives NULL Search context in webclient test window

VERIFIED FIXED

Status

Core Graveyard
Java APIs to WebShell
P3
normal
VERIFIED FIXED
17 years ago
5 years ago

People

(Reporter: Oleg Khokhlov, Assigned: Ashu Kulkarni)

Tracking

Trunk
x86
Windows NT

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Reporter)

Description

17 years ago
How to reproduce:

1. Run webclient test window and load any URL.
2. Find some string via Search->Find.
3. Close find dialog.
4. Try to find next string via Search->FindNext menu item.

  You will always receive the message: "NULL SearchContext received for 
FindNext".

It is because currentPage.resetFind() is invoked in file EMWindow.java in method 
dialogDismissed(Dialog d).	

May be it's better to make separate menu item for ResetFind?

Mozilla M16 and Webclient source from Sep 04,2000.

P.S. And also currentPage.resetFind() is in method dialogCancelled(Dialog d).

Comment 1

17 years ago
reassign ashu.
Assignee: edburns → ashuk
(Assignee)

Comment 2

17 years ago
This is part of the Test application code. There is no problem with the
underlying Webclient API code and as the Test code is only a sample for the
Webclient users to build upon, I would not treat this as a Webclient bug.

Nevertheless, I will fix this behavior in the EMWindow code such that it mimics
the actions of the Mozilla browser.

_accept.

_Ashu
Status: NEW → ASSIGNED
(Assignee)

Comment 3

17 years ago
Created attachment 14418 [details] [diff] [review]
Proposed patch - diff -u EMWindow.java
(Assignee)

Comment 4

17 years ago
Created attachment 14420 [details]
tar.gz of modified patch file

Comment 5

17 years ago
Comments on http://bugzilla.mozilla.org/showattachment.cgi?attach_id=14418 :

Ashu, I don't like commented out code.  Please remove the commented out code in 
the fix and re-format the impacted lines.  If you do that, I give r=,a= edburns.
(Assignee)

Comment 6

17 years ago
Created attachment 14494 [details] [diff] [review]
Proposed patch - diff -u EMWindow.java
(Assignee)

Comment 7

17 years ago
Made changes in EMWindow such that resetFind is called only when the "clear"
button is selected. This mimics the behavior of mozilla/Netscape 4.x and IE.
There is no separate ResetFind button.

_Ashu
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 8

17 years ago
Works for Me
Platform: PC
OS: Windows 98
Mozilla Version: 2000100508

Marking as Verified
Status: RESOLVED → VERIFIED
Component: Java APIs to WebShell → Java APIs to WebShell
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.