OS/2 NSPR part don't link against external libs that are stubs when the real function is in libc

VERIFIED FIXED in 4.8.1

Status

NSPR
NSPR
VERIFIED FIXED
9 years ago
8 years ago

People

(Reporter: Walter Meinl, Assigned: Dave Yeo)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

9 years ago
User-Agent:       Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.9.1.2) Gecko/20090802 Firefox/3.5.2
Build Identifier: 

As discussed in bug512504 and bug511945c#8 we don't need to link against dl and socket as these functions are in our libc and those libraries are only stubs. The patch for the main tree is in bug512504, here are the NSPR bits.

Reproducible: Always
(Reporter)

Comment 1

9 years ago
Created attachment 396864 [details] [diff] [review]
Daves NSPR patch fromb bug512504

Wan-Teh, Peter suggested in bug512504 that the NSPR patch attached there (originally https://bug512504.bugzilla.mozilla.org/attachment.cgi?id=396641, modified to fit to CVS needs: https://bug512504.bugzilla.mozilla.org/attachment.cgi?id=396681) should have a separate bug and be reviewed by you. Thanks
Attachment #396864 - Flags: review?(wtc)

Updated

9 years ago
Attachment #396864 - Flags: review?(wtc) → review+

Comment 2

9 years ago
Comment on attachment 396864 [details] [diff] [review]
Daves NSPR patch fromb bug512504

r=wtc.  Thanks for the patch.  I checked it in on the NSPR trunk (NSPR 4.8.1).

Checking in configure;
/cvsroot/mozilla/nsprpub/configure,v  <--  configure
new revision: 1.260; previous revision: 1.259
done
Checking in configure.in;
/cvsroot/mozilla/nsprpub/configure.in,v  <--  configure.in
new revision: 1.264; previous revision: 1.263
done

Updated

9 years ago
Assignee: wtc → daveryeo
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.8.1
(Reporter)

Updated

8 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.