Closed
Bug 512809
Opened 15 years ago
Closed 15 years ago
signup form uses colors for input validation feedback
Categories
(Firefox :: Sync, defect, P1)
Firefox
Sync
Tracking
()
VERIFIED
FIXED
0.7
People
(Reporter: hello, Assigned: hello)
References
Details
Attachments
(1 file)
10.92 KB,
patch
|
Mardak
:
review+
|
Details | Diff | Splinter Review |
It was a quick hack, and needs to be replaced with something more accessible. Not everyone can see red/green.
Updated•15 years ago
|
Target Milestone: --- → 0.7
Updated•15 years ago
|
Priority: -- → P1
Assignee | ||
Updated•15 years ago
|
Priority: P1 → P2
Updated•15 years ago
|
Priority: P2 → P1
Updated•15 years ago
|
Assignee: nobody → thunder
Assignee | ||
Comment 1•15 years ago
|
||
Patch also includes some extra unrelated stuff to implement the start over bubble.
Attachment #402778 -
Flags: review?(edilee)
Assignee | ||
Comment 2•15 years ago
|
||
I should also note that the patch doesn't fix all of the problems we currently have with error reporting in about:weave, or all the instances where we use colors in fields. But it's a definite improvement over what we currently do.
Comment 3•15 years ago
|
||
http://hg.mozilla.org/labs/weave/rev/2849b32ac6b5
Add initial error reporting and "available" tagging. Also add "start over" functionality and change some custom settings display.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Updated•15 years ago
|
Attachment #402778 -
Flags: review?(edilee) → review+
Comment 4•15 years ago
|
||
Comment on attachment 402778 [details] [diff] [review]
Use text (in addition to colors)
http://hg.mozilla.org/labs/weave/rev/40eb7be53737
Wire up "custom" inputs to set/read and show/hide server url box.
Comment 5•15 years ago
|
||
http://hg.mozilla.org/labs/weave/rev/fef981c73dd5
Reload the page instead of ending up with nothing when clicking "cancel" from start over.
Comment 6•15 years ago
|
||
http://hg.mozilla.org/labs/weave/rev/31f470639028
Add some account creation error handling, but it's still pretty clunky with username detection and alerts for other stuff.
Updated•6 years ago
|
Component: Firefox Sync: UI → Sync
Product: Cloud Services → Firefox
You need to log in
before you can comment on or make changes to this bug.
Description
•