Closed Bug 512809 Opened 13 years ago Closed 13 years ago

signup form uses colors for input validation feedback

Categories

(Firefox :: Sync, defect, P1)

defect

Tracking

()

VERIFIED FIXED

People

(Reporter: hello, Assigned: hello)

References

Details

Attachments

(1 file)

It was a quick hack, and needs to be replaced with something more accessible.  Not everyone can see red/green.
Blocks: 511688
Target Milestone: --- → 0.7
Priority: -- → P1
Priority: P1 → P2
Priority: P2 → P1
Assignee: nobody → thunder
Patch also includes some extra unrelated stuff to implement the start over bubble.
Attachment #402778 - Flags: review?(edilee)
I should also note that the patch doesn't fix all of the problems we currently have with error reporting in about:weave, or all the instances where we use colors in fields.  But it's a definite improvement over what we currently do.
http://hg.mozilla.org/labs/weave/rev/2849b32ac6b5
Add initial error reporting and "available" tagging. Also add "start over" functionality and change some custom settings display.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Attachment #402778 - Flags: review?(edilee) → review+
Comment on attachment 402778 [details] [diff] [review]
Use text (in addition to colors)

http://hg.mozilla.org/labs/weave/rev/40eb7be53737
Wire up "custom" inputs to set/read and show/hide server url box.
http://hg.mozilla.org/labs/weave/rev/fef981c73dd5
Reload the page instead of ending up with nothing when clicking "cancel" from start over.
http://hg.mozilla.org/labs/weave/rev/31f470639028
Add some account creation error handling, but it's still pretty clunky with username detection and alerts for other stuff.
Verified fix on weave 1.3b5.
Status: RESOLVED → VERIFIED
Component: Firefox Sync: UI → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.