Closed Bug 512830 Opened 10 years ago Closed 10 years ago

Remove search engine options: answers, creativecommons, ebay

Categories

(Firefox for Android Graveyard :: General, defect)

All
macOS
defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: stechz, Assigned: stechz)

Details

(Keywords: productization)

Attachments

(1 file, 1 obsolete file)

Should just involve removing files from mozilla/mobile/locales/en-US/searchplugins/ and update list.txt.
Comment on attachment 397144 [details] [diff] [review]
Remove search engines, flex buttons to fill space

Ben, we now have the ability to add new search providers dynamically. So the user can go to bugzilla.mozilla.org, click the site button (larry) and add the bugzilla search provider.

Please make sure that setting the flex to eagerly doesn't mess up the scroll/pan of the search provider bar if it overflows because a user adds a few new providers.
Comment on attachment 397144 [details] [diff] [review]
Remove search engines, flex buttons to fill space

>diff -r 7c77bce71c9a -r ba9e7aadb26e themes/hildon/browser.css

>+#search-buttons {
>+  -moz-box-flex: 1;
>+}
>+
> .searchengine {
>   -moz-box-orient: horizontal;
>+  -moz-box-flex: 1;
>+  min-width: 60px;
> }


Also, remember to add this to themes/wince/browser.css. Lastly, change the 60px to a millimeter size: 60px -> 14.4mm on hildon (it's really 7.2mm, but we have a bug to fix that) and use 7.2mm on wince.
Attachment #397144 - Attachment is obsolete: true
Attachment #397289 - Flags: review?(mark.finkle)
Attachment #397289 - Flags: review?(mark.finkle) → review+
I needed to remove the flexes to get correct support for panning to work, when adding more providers than can be displayed.

I will land with those changes.
pushed: http://hg.mozilla.org/mobile-browser/rev/76483b0ba9ab
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Please add the productization l10n folks on bugs like this.
Keywords: productization
verified with 20090914 1.9.2 nightly on my n810
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.