512841 - All forum posts come from Netscaler

Status: RESOLVED FIXED

(support.mozilla.org :: Forum, task)

Description

[James Socol [:jsocol, :james]]

The `user_ip` field of the tiki_comments table is populated with the Netscaler IP address (10.2.81.4) instead of the user's IP. We can probably steal the hack from bug 506547 comment 6 to fix it.

Comment 1

[James Socol [:jsocol, :james]]

Attachment: patch, v1

Modifies commentslib.php to check for an X-Forwarded-For header instead of assuming the $_SERVER['REMOTE_ADDR'] is correct.

Comment 2

[James Socol [:jsocol, :james]]

Comment on attachment 397697 [details] [diff] [review]
patch, v1

I'd like to get this in 1.4.2 if possible, since the patch exists already.

Comment 3

[Paul Craciunoiu [:paulc]]

(In reply to comment #2)
I'm gonna need some assistance for how to review this. Show me on Friday?

Comment 4

[Chris Ilias [:cilias]]

Moving to 1.4.2 per comment 2.
Is this the same bug as your reply to a thread not being visible right after you've posted? If so, it may be 1.4.1 worthy.

Comment 5

[James Socol [:jsocol, :james]]

Not at all. That looks like a caching or replication lag issue. This is just preventing every forum post from having the same originating IP address.

Comment 6

[Paul Craciunoiu [:paulc]]

Comment on attachment 397697 [details] [diff] [review]
patch, v1

This doesn't regress current functionality on my local, I get 127.0.1.2 (my setup) when posting a new forum question/reply

Hope that's a good enough test.

Comment 7

[James Socol [:jsocol, :james]]

Comment on attachment 397697 [details] [diff] [review]
patch, v1

I have code in the patch to bug 409942 that obsoletes this and helps us avoid duplicating chunks.

Comment 8

[James Socol [:jsocol, :james]]

Attachment: patch, v2

This patch depends on attachment 405950 [details] [diff] [review] from bug 409942.

Comment 9

[Paul Craciunoiu [:paulc]]

Comment on attachment 405951 [details] [diff] [review]
patch, v2

WFM

Comment 10

[James Socol [:jsocol, :james]]

r54274

See attachment 408132 [details] [diff] [review] from bug 409942.

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

James, is this verifiable on the frontend?

Comment 12

[Louis-Philippe Huberdeau]

$tikilib->get_ip_address() was introduced in tiki, which has a similar effect. Minor adjustments were made.

Comment 13

[James Socol [:jsocol, :james]]

$tikilib->get_ip_address() in SVN right now is backwards. It needs to check for the X-Forwarded-For header first.

Comment 14

[James Socol [:jsocol, :james]]

Oh, never mind, I mentally inserted an "else" into that snippet.