Closed Bug 512884 Opened 15 years ago Closed 15 years ago

nsStringGlue should be used in nsIPluginInstance.h

Categories

(Core Graveyard :: Plug-ins, defect)

x86
Linux
defect
Not set
normal

Tracking

(status1.9.2 .4-fixed)

RESOLVED FIXED
mozilla1.9.3a2
Tracking Status
status1.9.2 --- .4-fixed

People

(Reporter: romaxa, Assigned: romaxa)

References

Details

Attachments

(1 file)

nsIPluginHost.h has ifdef MOZILLA_INTERNAL_API for nsString.h and nsNetUtil.h
but not for nsPluginNativeWindow.h is including nsIPluginInstance.h and last including nsString.h without any ifdef
http://mxr.mozilla.org/mozilla-central/source/modules/plugin/base/public/nsIPluginInstance.idl#46
Attachment #396943 - Flags: review?(jst)
Attachment #396943 - Flags: superreview+
Attachment #396943 - Flags: review?(jst)
Attachment #396943 - Flags: review+
Fixed in:
http://hg.mozilla.org/mozilla-central/rev/63827dece734
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Comment on attachment 396943 [details] [diff] [review]
nsStringGlue for nsIPluginInstance.idl

We needed to land this on 1.9.2 as well; as it stands this header is not usable by embedders on that branch...
Attachment #396943 - Flags: approval1.9.2.2?
Attachment #396943 - Flags: approval1.9.2.2? → approval1.9.2.3+
Assignee: nobody → romaxa
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: