Closed
Bug 512884
Opened 16 years ago
Closed 16 years ago
nsStringGlue should be used in nsIPluginInstance.h
Categories
(Core Graveyard :: Plug-ins, defect)
Tracking
(status1.9.2 .4-fixed)
RESOLVED
FIXED
mozilla1.9.3a2
| Tracking | Status | |
|---|---|---|
| status1.9.2 | --- | .4-fixed |
People
(Reporter: romaxa, Assigned: romaxa)
References
Details
Attachments
(1 file)
|
342 bytes,
patch
|
jst
:
review+
jst
:
superreview+
beltzner
:
approval1.9.2.4+
|
Details | Diff | Splinter Review |
nsIPluginHost.h has ifdef MOZILLA_INTERNAL_API for nsString.h and nsNetUtil.h
but not for nsPluginNativeWindow.h is including nsIPluginInstance.h and last including nsString.h without any ifdef
http://mxr.mozilla.org/mozilla-central/source/modules/plugin/base/public/nsIPluginInstance.idl#46
Attachment #396943 -
Flags: review?(jst)
|
||
Updated•16 years ago
|
Attachment #396943 -
Flags: superreview+
Attachment #396943 -
Flags: review?(jst)
Attachment #396943 -
Flags: review+
|
Assignee | |
Comment 1•16 years ago
|
||
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Comment 3•16 years ago
|
||
Comment on attachment 396943 [details] [diff] [review]
nsStringGlue for nsIPluginInstance.idl
We needed to land this on 1.9.2 as well; as it stands this header is not usable by embedders on that branch...
Attachment #396943 -
Flags: approval1.9.2.2?
|
||
Updated•16 years ago
|
Attachment #396943 -
Flags: approval1.9.2.2? → approval1.9.2.3+
|
||
Updated•16 years ago
|
Assignee: nobody → romaxa
|
||
Comment 4•16 years ago
|
||
status1.9.2:
--- → .4-fixed
Target Milestone: --- → mozilla1.9.3a2
|
||
Updated•4 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•