512890 - "ABORT: NULL content node" with SVG filter, em units

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Jesse Ruderman]

Attachment: testcase (triggers a fatal assertion when loaded)

###!!! ABORT: NULL content node: 'aContent', file /Users/jruderman/central/layout/style/nsComputedDOMStyle.cpp, line 376

This abort is part of code added in bug 507067.

Comment 1

[Jesse Ruderman]

Attachment: stack trace

Comment 2

[Brian Birtles (:birtles)]

Looks like we're trying to resolve em-based units in nsSVGUtils::ObjectSpace without the necessary context (which in this test case is probably the target <rect>).

Comment 3

[Robert Longson [:longsonr]]

Attachment: patch

This is consistent with what we do in nsSVGLength2::GetMMPerPixel(nsSVGSVGElement *aCtx) and nsSVGLength2::GetAxisLength(nsSVGSVGElement *aCtx)

Comment 4

[Robert Longson [:longsonr]]

pushed http://hg.mozilla.org/mozilla-central/rev/0754fabcdd2b and http://hg.mozilla.org/mozilla-central/rev/baf6eb94e8f5

Comment 5

[Robert Longson [:longsonr]]

Comment on attachment 400179 [details] [diff] [review]
patch

Simple fix to avoid crash

Comment 6

[Robert Longson [:longsonr]]

Comment on attachment 400179 [details] [diff] [review]
patch

Don't need this for 1.9.2 if we're not going to land  bug 507067 there.