Closed
Bug 512896
Opened 15 years ago
Closed 3 years ago
Deal with the unbuildable GenCyrillicClass.cpp
Categories
(Core :: Internationalization, defect)
Core
Internationalization
Tracking
()
RESOLVED
INVALID
People
(Reporter: philor, Assigned: smontagu)
References
Details
Attachments
(2 files)
5.10 KB,
patch
|
Details | Diff | Splinter Review | |
2.29 KB,
patch
|
smontagu
:
review+
|
Details | Diff | Splinter Review |
In theory, intl/chardet/tools/GenCyrillicClass.cpp builds a program which will generate intl/chardet/src/nsCyrillicClass.h. In fact, it's built by a makefile.win which includes config/rules.mak, which means it's been unbuildable since November 2004, and for its entire life (since July 1997) there's only been one non-license change, and that was made by changing GenCyrillicClass.cpp without building it or using it, and then three months later in a new bug hand-patching the supposedly-generated nsCyrillicClass.h. Even though we show no sign of having ever needed to regenerate it, that unusable makefile.win is a big fat deadcode target for bug 512497, and once it's gone there'll be no reminder that GenCyrillicClass.cpp is unbuildable. Other than this bug :)
Reporter | ||
Comment 1•15 years ago
|
||
This compiles, which is nice, but linking dies with Undefined symbols: "nsLowerUpperUtils::kLower2Upper", referenced from: __data@0 in GenCyrillicClass.o "nsCOMPtr_base::assign_from_gs_contractid_with_error(nsGetServiceByContractIDWithError const&, nsID const&)", referenced from: _main in GenCyrillicClass.o "nsCOMPtr_base::~nsCOMPtr_base()", referenced from: _main in GenCyrillicClass.o ld: symbol(s) not found collect2: ld returned 1 exit status which doesn't quite tell me what magic incantation it wants.
Reporter | ||
Comment 2•15 years ago
|
||
Fortunately, the makefile.win doesn't really offer any clues to modernizing, so we can just get rid of it.
Attachment #397563 -
Flags: review?(smontagu)
Assignee | ||
Updated•15 years ago
|
Attachment #397563 -
Flags: review?(smontagu) → review+
Reporter | ||
Comment 3•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/ec3c80346a84
Summary: Deal with the unbuildable GenCyrillicClass.cpp, and its little makefile.win, too → Deal with the unbuildable GenCyrillicClass.cpp
Comment 4•13 years ago
|
||
Can this now be resolved fixed?
Comment 5•12 years ago
|
||
(In reply to Ed Morley [:edmorley UTC+1] from comment #4) > Can this now be resolved fixed? I'm thinking no. Per comment 0, the removal of the makefile.win only means that this bug is the only indication that there is a problem with GenCyrillicClass.cpp; the problem still exists, AFAICT from this bug. (I haven't done any testing or anything.)
Reporter | ||
Comment 6•12 years ago
|
||
Wow, I ignored edmorley? Bad me. No, gphemsley is exactly right - the bug is about the first paragraph of comment 0, and the second paragraph and comment 2 and comment 3 are only about the reason why I found the thing it's about.
Comment 7•3 years ago
|
||
We don't have this file anymore.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•