512934 - runtests.py could produce a false configuration based on AVM path

Status: VERIFIED FIXED

(Tamarin Graveyard :: Build Config, defect)

Description

[Brent Baker]

Incidentally I noticed a problem with the way this detection works. You can get
a false positive from the file/directory name which file(1) prints out by
default. Eg passing --avm=/opt/appcore/tamarin-redux/objdir-mips/shell/avmshell
would convince the script it was running on ppc(!). Modern versions of file(1)
have a -b option to suppress the filename output, but for portability there
should be something like this in runtestBase.py:

             f = ' '.join(f)
+            f = f.replace(self.avm, '');
             self.verbose_print('determineConfig: %s' % f)

Comment 1

[Brent Baker]

Attachment: remove the path information to asc

Prior to patch config is miscalcuated:
determineConfig: /c/temp/appcore/avmshell.exe: MS-DOS executable PE  for MS Wind
ows (console) Intel 80386 32-bit
current configuration: ppc-win-tvm-release

With patch:
determineConfig: : MS-DOS executable PE  for MS Windows (console) Intel 80386 32
-bit
current configuration: x86-win-tvm-release

Comment 2

[Dan Schaffer]

Comment on attachment 396987 [details] [diff] [review]
remove the path information to asc

Looks fine.  Hopefully someone does not set their AVM=CYGWIN_NT

Comment 3

[Brent Baker]

patch pushed 2411:9324ad144e05