Closed Bug 513023 Opened 10 years ago Closed 10 years ago

Move about:rights content to toolkit

Categories

(Toolkit Graveyard :: XULRunner, defect)

defect
Not set

Tracking

(status1.9.2 beta1-fixed)

RESOLVED FIXED
mozilla1.9.3a1
Tracking Status
status1.9.2 --- beta1-fixed

People

(Reporter: Gavin, Assigned: Gavin)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

...so that it can easily be used in Fennec, or any other MPL-distributed app that wants to use it (thunderbird? seamonkey?)
Attached patch patch (obsolete) — Splinter Review
This just moves the content. Apps still need to implement their own nsIAboutModules to point to it.
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #397042 - Flags: review?(benjamin)
(In reply to comment #0)
> ...so that it can easily be used in Fennec, or any other MPL-distributed app
> that wants to use it (thunderbird? seamonkey?)

Assuming this applies to xulrunner apps, what would you do about the link contents?
Comment on attachment 397042 [details] [diff] [review]
patch

Since you're putting this in toolkit, it doesn't make much sense to keep the MOZILLA_OFFICIAL ifdefs. Whether XULRunner is compiled with MOZILLA_OFFICIAL isn't related to whether Firefox is, at least in some important cases such as Linux distros.
Attachment #397042 - Flags: review?(benjamin) → review-
(In reply to comment #2)
> (In reply to comment #0)
> > ...so that it can easily be used in Fennec, or any other MPL-distributed app
> > that wants to use it (thunderbird? seamonkey?)
> 
> Assuming this applies to xulrunner apps, what would you do about the link
> contents?

The current approach I've used is to separate the files based on the existing MOZILLA_OFFICIAL ifdefs - aboutRights.xhtml and aboutRights-unbranded.xhtml. The former is useful for apps that have Mozilla Foundation-owned branding (only Firefox and Fennec at the moment, I think), while the aboutRights-unbranded could be used, with a few modifications, by others who share the mozilla-project origin without necessarily having the same branding or web service/privacy policies (as well as being used by unofficial/unbranded firefox builds).
> The former is useful for apps that have Mozilla Foundation-owned branding (only
> Firefox and Fennec at the moment, I think), while the aboutRights-unbranded

Mozilla Foundation or Mozilla Co? Because I thought MoFo still owns Thunderbird and Sunbird via Mozilla Messaging. And Thunderbird is shadowing the Firefox branded/unbranded policies AFAIK.
If the "branded" version is suitable for other people as-is, they're free to use it too. I'm not a lawyer :)
Attached patch patchSplinter Review
Attachment #397042 - Attachment is obsolete: true
Attachment #397313 - Flags: review?(benjamin)
Attachment #397313 - Flags: review?(benjamin) → review+
I just see that dao landed this.

Gavin, was this the bug where you asked about moving l10n files?
http://hg.mozilla.org/mozilla-central/rev/0925624977a2
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
(In reply to comment #8)
> Gavin, was this the bug where you asked about moving l10n files?

Yes. Is there something I should do to make this easier for localizers? Post to m.d.l10n? CC the alias here?
A post to .l10n would be good.
Attachment #397313 - Flags: approval1.9.2?
Comment on attachment 397313 [details] [diff] [review]
patch

a=beltzner
Attachment #397313 - Flags: approval1.9.2? → approval1.9.2+
Had to tweak the 1.9.2 patch a little bit, since bug 499123 hasn't landed there:

https://hg.mozilla.org/releases/mozilla-1.9.2/rev/1ab406832d6a
Depends on: 514817
Blocks: 559816
No longer depends on: 514817
Depends on: 588916
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.