Closed Bug 513037 Opened 15 years ago Closed 15 years ago

Give "Archive" subfolders a different looking icon

Categories

(Thunderbird :: Folder and Message Lists, enhancement)

Product:
Thunderbird
Component:
Folder and Message Lists
Platform:
All
Windows Vista
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 3.0b4

People

(Reporter: brandt24, Assigned: andreasn)

Details

(Whiteboard: [no l10n impact])

Attachments

(3 files)

this is what I see
13.31 KB, image/pjpeg
Details
special folders
32.06 KB, image/pjpeg
Details
patch on trunk
9.00 KB, patch
philor
: review+
clarkbw
: ui-review+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.0; Trident/4.0; SLCC1; .NET CLR 2.0.50727; .NET CLR 3.0.30729; .NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1.4pre) Gecko/20090827 Shredder/3.0b4pre

Right now the Archive folders created use the default icon for a folder. It would be much useful if it would also have a dedicated icon and with the possibilty to change the color of the the subsequent subfolder icons.

Reproducible: Always
I'm fairly sure the sub-archive folders where specifically not given the generic icon for a reason. So this is probably wontfix. Leaving Bryan (our user experience expert) to comment though.

Colour coding folders is already covered by bug 508048.
Right now the Archive folder and it's subfolders all share the default folder icon.
Version: unspecified → 3.0
We tried a couple of different icon looks but nothing seemed correct.  I wouldn't mind a different look or no folder icon at all.  Someone should investigate more possibilities.  Also this won't get much priority for TB3 (unless someone puts in all the work) so I would look toward TB(next) for a change like this.
Version: 3.0 → unspecified
oh, cmon, how difficult can it be to design just one icon to give an impression of an archive? :))
"nothing seemed correct" - can you be more specific?
we have an archive icon - I assume you're just not seeing it for some reason, but you're having enough weird issues with your special folders that it's not surprising.
Attached image this is what I see — 

    
  
Version: unspecified → 3.0

    
    

    
  
yup, you're not seeing the archive icon for some reason. Is this an IMAP or local account?

    
    

    
  
It's a Vista account - we're temporarily missing the icon on Vista. Morphing to cover the only remaining issue that probably isn't a dupe.
Summary: Give "Archive" folders a different looking icon → Give "Archive" subfolders a different looking icon

    
    

    
  
IMAP, but you are right about the special folders, there seems to be something wrong with them.

    
    

    
  

      
      
      
      

        Attached image
          
        special folders
        — 
      

    


  

    
    

    
  
Hmm, my Vista install is all over the floor right now, but I didn't notice the Archive icon being missing - perhaps I was out of date.

    
    

    
  
So, David, if you take a look at the Smart Folders screenshot that I put up here, what do you say? Do you think these two issues might be connected to eachother?

    
    

    
  
If Phil says we're missing the archive icon on Vista, I believe him.

    
    

    
  
Ok, sorry, just got confused for a moment there.

    
    

    
  
confirming, on the assumption that this isn't a dup. I think this would be nice to have for b4
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: blocking-thunderbird3+
Target Milestone: --- → Thunderbird 3.0rc1

    
    

    
  
assigning to andreas.

we have some other priorities but it would be good to get this in for b4 if possible.
Assignee: nobody → nisses.mail

    
    

    
  
I see this on my Vista install to. Will fix!

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch on trunk
        — 
          — Splinter Review
      

    


  

        Attachment #399427 -
        Flags: ui-review?(clarkbw)

        Attachment #399427 -
        Flags: review?(philringnalda)

        Attachment #399427 -
        Flags: review?(philringnalda) → review+

    
    

    
  
Comment on attachment 399427 [details] [diff] [review]
patch on trunk

Huh, I thought when I morphed this to being about using the icon for subfolders of an archive folder that someone had reopened bug 488668 for it being missing entirely, but apparently not.

    
    

    
  
Comment on attachment 399427 [details] [diff] [review]
patch on trunk

looks good

        Attachment #399427 -
        Flags: ui-review?(clarkbw) → ui-review+

    
    

    
  
hoping for another approval‑thunderbird3+ from mark :)
Keywords: checkin-needed
Hardware: x86 → All
Target Milestone: Thunderbird 3.0rc1 → Thunderbird 3.0b4
Version: 3.0 → Trunk

    
    

    
  
(In reply to comment #22)
> hoping for another approval‑thunderbird3+ from mark :)

You don't need approval on a blocking-thunderbird3+ bug...

    
    

    
  
(In reply to comment #23)
> You don't need approval on a blocking-thunderbird3+ bug...

completely forgot this was blocking
Status: NEW → ASSIGNED
Whiteboard: [needs checkin]
Whiteboard: [needs checkin] → [no l10n impact][needs checkin]

    
    

    
  
Checked in: http://hg.mozilla.org/comm-central/rev/2fd594cd8de6
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [no l10n impact][needs checkin] → [no l10n impact]

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: