Closed
Bug 513049
Opened 16 years ago
Closed 16 years ago
TM: add env var to force-disable SSE
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| status1.9.2 | --- | beta1-fixed |
People
(Reporter: graydon, Assigned: graydon)
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
|
461 bytes,
patch
|
gal
:
review+
|
Details | Diff | Splinter Review |
Our SSE-detection code is unconditional. Sometimes -- mainly for testing -- it's useful to force-disable SSE and fall back to x87. We have support for this kind of thing in the ARM code already, just not x86.
The attached patch adds a corresponding x86 env var.
Attachment #397079 -
Flags: review?(gal)
|
||
Comment 1•16 years ago
|
||
Comment on attachment 397079 [details] [diff] [review]
Add env var
How about we just add an option to TMFLAGS for this? Like "nosse" and "sse"?
Attachment #397079 -
Flags: review?(gal) → review+
|
||
Comment 2•16 years ago
|
||
Well, it's kinda a misuse of it. So far TMFLAGS controls debug output,
but it doesn't influence the "end-user" output of the program.
Maybe a different env var?
|
Assignee | |
Comment 3•16 years ago
|
||
As I said in the bug, there are already ARM_FORCE_HWCAP and ARM_FORCE_PLATFORM variables read in the ARM-specific setup code, I am just mimicking that.
|
|
Assignee | |
Comment 4•16 years ago
|
||
Whiteboard: fixed-in-tracemonkey
|
||
Comment 5•16 years ago
|
||
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Comment 6•16 years ago
|
||
status1.9.2:
--- → beta1-fixed
Flags: wanted1.9.2+
You need to log in
before you can comment on or make changes to this bug.
Description
•