513135 - [1.3.2] Add-on Validator page for non-hosted add-ons

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P1)

Description

[Justin Scott [:fligtar]]

One of the tools available in the developer hub is the add-on validator even if the add-on is not hosted on AMO.

I will attach a mockup here and more details shortly.

Comment 1

[Justin Scott [:fligtar]]

Attachment: mockup

* The Validator page of the developer hub should have a brief introductory paragraph, followed by 2 methods of running the validation tests.
* If the user is not logged-in, instead of the area to select the add-on/file, there should be text that says "You must _log_in_ to validate an add-on". We don't want random people uploading crap.
* If the user is logged-in and has add-ons hosted, they should see the dropdown shown in the mockup where selecting one of their add-ons will take them to the versions & files page for that add-on so they can run tests.
* All logged-in users should see the second part, where an add-on can be uploaded to be tested. The validator should run the tests for this add-on and immediately the delete the file.

Comment 2

[Justin Scott [:fligtar]]

RJ, I know it's your last day tomorrow. If at all possible, could you take a look at implementing a new page in the dev tools with the upload box that takes any add-on regardless of hosted status? We can work on implementing the rest of the UI for this page, but it would definitely help if you could do the upload and validation part.

Comment 3

[RJ Walsh [:rjwalsh]]

Justin - This should be pretty easy to implement now that validation on upload is working.  Even if this isn't done by tomorrow, school doesn't really start for a few weeks, so I can help out here and there where needed.

Comment 4

[RJ Walsh [:rjwalsh]]

Attachment: v1

First stab at this - look for the new 'Validate add-on' link in the developer sidebar

Comment 5

[Wil Clouser [:clouserw]]

Comment on attachment 397332 [details] [diff] [review]
v1

The design is fine, but you're duplicating big chunks of code from uploader.thtml.  If that code is going to exist in more than 1 place it should be under /views/elements

Comment 6

[RJ Walsh [:rjwalsh]]

Attachment: v2, refactored

Comment 7

[Wil Clouser [:clouserw]]

Comment on attachment 397345 [details] [diff] [review]
v2, refactored

You're probably going to get some conflicts with the new dev nav bar

Comment 8

[RJ Walsh [:rjwalsh]]

Fixed in r51313

Comment 9

[Milos Dinic [:Milos]]

When on https://preview.addons.mozilla.org/en-US/developers/addon/validate , logged in as admin, I do select an add-on hosted by AMO, and it takes me to https://developers/addon/validate/$addonid

Anyway, it works if a one uploads an add-on.

Comment 10

[RJ Walsh [:rjwalsh]]

Attachment: Fix for comment #9

Removing an unnecessary /

Comment 11

[RJ Walsh [:rjwalsh]]

Fixed in r52388

Comment 12

[Milos Dinic [:Milos]]

I get "No test results found." for any test group now. When i upload addon for validation, it looks like it actually running some tests, and when I test uploaded addon, it just gives me that notification.

Tests for uploaded addon are still working fine.

Comment 13

[RJ Walsh [:rjwalsh]]

(In reply to comment #12)
> I get "No test results found." for any test group now. 

This is because it just takes you to the validation page, but does not actually run any tests.  We could add that, but it changes the scope of the bug.

Comment 14

[Milos Dinic [:Milos]]

But what's the purpose of another method than(other than upload)? As far as I can see, Justin wanted both methods working.

Comment 15

[RJ Walsh [:rjwalsh]]

Milos, have you clicked on the validate button?  It's a bit hidden now since it's not styled, but that runs the validation tests on that page.

Comment 16

[Wil Clouser [:clouserw]]

Works fine when I try it using both the drop down and uploading a new file.

Comment 17

[Milos Dinic [:Milos]]

Yes. Verified on https://preview.addons.mozilla.org/en-US/developers/addon/validate/11135 .