513136 - [1.3.1] Add-on Builder

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P1)

Description

[Justin Scott [:fligtar]]

We will have an installation of Fizzypop on the new developer hub. I will post a mockup and details on this shortly.

Comment 1

[Justin Scott [:fligtar]]

Attachment: Landing page mockup

Comment 2

[Justin Scott [:fligtar]]

Attachment: Extension builder mockup

Comment 3

[Justin Scott [:fligtar]]

Attachment: extension builder wireframe

Comment 4

[Justin Scott [:fligtar]]

Attachment: last step wireframe

Comment 5

[Justin Scott [:fligtar]]

Please implement the attached mockups with the following provisions:
* This page's URL should be /developers/tools/builder
* The main page for the builder looks very similar to the Add-on Collector and will have copy soon.
* We will have a logo made for this page, but for now, please use the collections logo
* The More Options box should be called More Tools and have "Application Builder", "Component Builder", and "Add-on Validator" links only.
* This will use FizzyPop from SVN: http://svn.mozilla.org/projects/fizzypop/ (currently installed here: http://starkravingfinkle.org/projects/fizzypop/)
* The steps should be laid out as shown in the wireframe, although I'd like for them to all be shown instead of a multi-step process, so you can remove the "Step x of 4" labels.
* Upon submitting the form, the last step wireframe should be shown. This last step should also show the "More Tools" box.
* If there are any bugs in FizzyPop itself, please file them and assign to Cesar.

* As lower priority, please also lay out the steps of the Application Builder and Component Builder like the add-on builder.

Comment 6

[Justin Scott [:fligtar]]

The image to use for this page is now in svn at app/webroot/img/amo2009/developers/addon-builder.png

Comment 7

[Justin Scott [:fligtar]]

Talked about this with Jeff, trying to figure out the best way to integrate FizzyPop such that we get upstream fixes and additions.

Although we announced our intention to do this a number of months ago, MozDev launched a FizzyPop implementation recently @ http://www.mozdev.org/projects/wizard/extension/

Their implementation has a number of things we won't do, like several new types for Songbird add-ons. Judging by their filed bugs, they want to continue to improve support for these other applications that AMO doesn't support, so I told Jeff that we should only support Add-ons and Components, and have a link to the MozDev wizard for other applications.

We should support install.rdf versioning for all of our supported apps, but not others. Ideally we would include FizzyPop as an external/vendor and only change front-end stuff, but I haven't looked at the code so I don't know if that's possible. Jeff will decide the best way to implement it, trying to be as open source spirity as possible.

Comment 8

[Doug Warner]

Justin,

Mozdev made a number of improvements to Fizzypop that we're working on getting upstream that is documented in bug#505441.  The short of it is we tried to separate the front-end and back-end (web forms, project templates, and zip composition) so it was easier to add new project types.  The version of Fizzypop we're using can be found here: http://hg.mozdev.org/hovercraft/fizzypop/

We would like to include support for each project type directly in Fizzypop since this would provide the easiest mechanism for others to be able to benefit from all the template projects available.  Perhaps we can come up with an easy way to limit which project types are listed.

W.R.T. components, it was brought up on our website that we should probably be pursuing JS Modules instead (bug#514440).

Feel free to catch me on IRC if you would like to discuss any of the changes Mozdev has made to Fizzypop.

Comment 9

[Jeff Balogh (:jbalogh)]

Attachment: add-on builder

Only missing the intro page.  I'm going to attach the stuff in vendors separately so it doesn't overload this patch.

Comment 10

[Jeff Balogh (:jbalogh)]

Attachment: dependencies for the add-on builder: fizzypop and phorms

Comment 11

[Jeff Balogh (:jbalogh)]

(In reply to comment #9)
> Created an attachment (id=401575) [details]
> add-on builder
> 
> Only missing the intro page.  I'm going to attach the stuff in vendors
> separately so it doesn't overload this patch.

And this doesn't have the tips on the help boxes yet.  I'll probably need some rdoherty help there.

Comment 12

[Jeff Balogh (:jbalogh)]

Attachment: add-on builder

adding the help box pointer and the migration

Comment 13

[Wil Clouser [:clouserw]]

Comment on attachment 401588 [details] [diff] [review]
add-on builder

This works.  There isn't really any validation so it's possible to make invalid install.rdf files.  That doesn't really bother me too much, but I am a little concerned that the filename is unescaped in the Content-Disposition header (so I can break out of the quotes).  I haven't been able to inject an attack in it yet but can we run that through the INVALID_FILENAME_CHARS constant before serving it?

Comment 14

[Wil Clouser [:clouserw]]

Comment on attachment 401578 [details] [diff] [review]
dependencies for the add-on builder: fizzypop and phorms

Are these just trunk builds?  I'll r+ but they should both be added as SVN externals to the project, not checked in to the tree.

> phorms

sigh

Comment 15

[Justin Scott [:fligtar]]

This was r+'d on Friday and as far as I know is still blocking l10n. What's the status of check-in?

Comment 16

[Jeff Balogh (:jbalogh)]

The builder is in r51983, externals updated in r51984.

Comment 17

[Jeff Balogh (:jbalogh)]

After chatting with fligtar in real life, we're scrapping the landing page so this bug is done.

Comment 18

[Justin Scott [:fligtar]]

Finished the copy for the Builder pages. Remaining fixes for the builder filed as bug 517965.

Comment 19

[Milos Dinic [:Milos]]

Verified fixed on https://preview.addons.mozilla.org/en-US/developers and https://preview.addons.mozilla.org/en-US/developers/tools/builder .