513139 - TM: remove savedRegs hack from nanojit

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Comment 1

[Andreas Gal :gal]

Attachment: patch

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

breaking test case - stack misalignment

function stringConvert()
{
  var a;
  for (var i = 0; i < 10; i++) {
    a = "5" & "7";
  }
  return a.toString();
}
stringConvert();

Comment 3

[Andreas Gal :gal]

Attachment: patch

Comment 4

[Andreas Gal :gal]

Attachment: patch

fixed regexp jit

Comment 5

[Andreas Gal :gal]

The patch also removes LIR_loop. We use LIR_j to jump back to the loop header on trace, and LIR_x for branch traces to get back to the root fragment. The latter should be optimized further.

Comment 6

[Andreas Gal :gal]

Attachment: patch

Comment 7

[Nicholas Nethercote [inactive]]

Comment on attachment 397180 [details] [diff] [review]
patch

> /* guards */
>-OPDEF(loop,     17, 0, Op2)     // loop fragment
>+OPDEF(unused17, 17, 0, None)    // loop fragment

Nit: remove comment.


Will this play nicely with Tamarin?

Comment 8

[Andreas Gal :gal]

Thanks for the nit. Tamarin doesn't use loop. They don't use the implicit saveRegs hack either. They will be happy both are gone.

Comment 9

[Nicholas Nethercote [inactive]]

Good.  I'm happy too, less code is a win!

Comment 10

[Andreas Gal :gal]

http://hg.mozilla.org/tracemonkey/rev/1e581a31c017

Comment 11

[Blake Kaplan (:mrbkap) (inactive)]

http://hg.mozilla.org/mozilla-central/rev/1e581a31c017

Comment 12

[Robert Sayre]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/21d142b4c608