Status
People
(Reporter: treilly, Assigned: treilly)
Tracking
Details
Attachments
(1 attachment)
|
3.48 KB,
patch
|
lhansen
:
superreview-
|
Details | Diff | Splinter Review |
Created attachment 397200 [details] [diff] [review] p4 diff2 patch
Attachment #397200 -
Flags: superreview?(lhansen)
|
||
Comment 1•9 years ago
|
||
Comment on attachment 397200 [details] [diff] [review] p4 diff2 patch This introduces a parameter on the critical path where one is not needed. It should be sufficient - if I've understood it correctly - for the isFixedAllocSafe flag to be set in FixedAlloc's constructor, and then picked up by CreateChunk.
Attachment #397200 -
Flags: superreview?(lhansen) → superreview-
|
(Assignee) | |
Comment 2•9 years ago
|
||
that works for me, can I consider this +'d if I make that change?
|
|
||
Comment 3•9 years ago
|
||
(In reply to comment #2) > that works for me, can I consider this +'d if I make that change? Yeah, that should be OK.
|
|
(Assignee) | |
Comment 4•9 years ago
|
||
changeset: 2433:f1ed8a71f419
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
|
||
Updated•9 years ago
|
||
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•