513195 - make xpcshell-tests & check-one & check interactive broken for c-c

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Description

[Mark Banner (:standard8)]

Attachment: The fix [Checkin: Comment 5]

Bug 483062 landed on branch yesterday which changed the arguments the xpcshell-tests code requires. We need to sync our configuration to mozilla-1.9.1 so that it works again in mailnews and other sub directories.

The make xpcshell-tests at a global level isn't broken as that is driven from the mozilla-1.9.1 build system.

Patch attached that is sufficient to unbreak those commands. If I get chance later I'll see if there's anything extra we need to do to get crash symbols in the tests.

Comment 1

[Robert Kaiser]

Comment on attachment 397224 [details] [diff] [review]
The fix
[Checkin: Comment 5]

> xpcshell-tests:

Any idea why this is called "xpcshell-tests" for us but "check" for Mozilla in rules.mk?

Comment 2

[Mark Banner (:standard8)]

(In reply to comment #1)
> (From update of attachment 397224 [details] [diff] [review])
> > xpcshell-tests:
> 
> Any idea why this is called "xpcshell-tests" for us but "check" for Mozilla in
> rules.mk?

Just discussed with KaiRo on irc... this is the patch on bug 483062 which was from the days when we used to run xpcshell tests and cpp tests from the one "make check" command.

Comment 3

[Serge Gautherie (:sgautherie)]

(In reply to comment #0)
> We need to sync our configuration to
> mozilla-1.9.1 so that it works again in mailnews and other sub directories.

Sorry, I didn't think about c-c, as there had been no patch for "trunk" before :-<

Thanks for porting it.

Comment 4

[Mark Banner (:standard8)]

(In reply to comment #0)
> Patch attached that is sufficient to unbreak those commands. If I get chance
> later I'll see if there's anything extra we need to do to get crash symbols in
> the tests.

I've just done some digging, AFAICT SeaMonkey has all the necessary items in place to generate crash symbols.

Thunderbird needs some extra work, so I've raised bug 519182 for that.

Comment 5

[Serge Gautherie (:sgautherie)]

Comment on attachment 397224 [details] [diff] [review]
The fix
[Checkin: Comment 5]


http://hg.mozilla.org/comm-central/rev/9cac0431ec52