Tracemonkey build failed on solairs at jsnum.h.

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: Leon Sha, Assigned: Leon Sha)

Tracking

unspecified
x86
Solaris
Points:
---
Bug Flags:
wanted1.9.2 +

Firefox Tracking Flags

(status1.9.2 beta1-fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
This bug happened after the fix for bug 513063 commited.
"jsnum.h", line 98: Error: The function "finite" must have a prototype.
"jsnum.h", line 109: Error: The function "isinf" must have a prototype.
"jsnum.h", line 119: Error: The function "signbit" must have a prototype.
"jsnum.h", line 141: Error: The function "signbit" must have a prototype.
(Assignee)

Comment 1

9 years ago
Created attachment 397237 [details] [diff] [review]
patch
Attachment #397237 - Flags: review?(gal)

Updated

9 years ago
Attachment #397237 - Attachment is patch: true
Attachment #397237 - Attachment mime type: application/octet-stream → text/plain

Comment 2

9 years ago
Comment on attachment 397237 [details] [diff] [review]
patch

Thanks Leon!
Attachment #397237 - Flags: review?(gal) → review+

Comment 3

9 years ago
Comment on attachment 397237 [details] [diff] [review]
patch

>diff --git a/js/src/jsnum.h b/js/src/jsnum.h

> static inline int
> JSDOUBLE_IS_NEGZERO(jsdouble d)
> {
> #ifdef WIN32
>     return (d == 0 && (_fpclass(d) & _FPCLASS_NZ));
>+#elif defined(SOLARIS)
>+    return (d == 0 && copysign (1, d) < 0);
> #else
>     return (d == 0 && signbit(d));
> #endif
> }

There shouldn't be a space after copysign...

> static inline int
> JSDOUBLE_IS_NEG(jsdouble d)
> {
> #ifdef WIN32
>     return JSDOUBLE_IS_NEGZERO(d) || d < 0;
>+#elif defined(SOLARIS)
>+    return copysign (1, d) < 0;
> #else
>     return signbit(d);
> #endif
> }

...nor here either.
(Assignee)

Comment 4

9 years ago
http://hg.mozilla.org/tracemonkey/rev/ec373946e8bf
Assignee: general → leon.sha
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED

Comment 7

9 years ago
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/3629e873d586
status1.9.2: --- → beta1-fixed
Flags: wanted1.9.2+
You need to log in before you can comment on or make changes to this bug.