513215 - [shared module] Modal dialog needs an initial timeout value to prevent fetching the wrong modal window

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Patch v1

While running the Mozmill tests in a row on Windows today I have noticed that under some circumstances the modal dialog API gets the wrong modal window. That can happen if it takes a bit longer to open the dialog. At the moment we have a delay of 100ms before the observer is fired the first time. That is way to fast and we should give the users a way to set this value. This will at least prevent catching the wrong window when looking at the timing. But we cannot differentiate if we really have another window as top most window.

As example: On bug 502159 we test the preferred language. Opening the language dialog inside the preferences takes a while too long because all the languages are retrieved first. When the dialog gets opened our observer has already caught the preference window itself as the new modal dialog. So the remaining tests will fail in this module.

It has me taken a while until I was able to figure out what's going on.

Comment 1

[cmtalbert]

Comment on attachment 397248 [details] [diff] [review]
Patch v1

nice catch, thanks whimboo

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/636225b74d1c
http://hg.mozilla.org/qa/mozmill-tests/rev/2787871de5be

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Mass move of Mozmill Test related project bugs to newly created components. You can filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.