Method findNextInPage(boolean forward) doesn't use its forward parameter

VERIFIED FIXED

Status

Core Graveyard
Java APIs to WebShell
P3
normal
VERIFIED FIXED
17 years ago
5 years ago

People

(Reporter: Oleg Khokhlov, Assigned: Ashu Kulkarni)

Tracking

Trunk
x86
Windows NT

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Reporter)

Description

17 years ago
Method findNextInPage(boolean forward) doesn't use its forward parameter (see 
CurrentPage.cpp)
This method use forward parameter, which was set in findInPage(java.lang.String 
stringToFind, boolean forward, boolean matchCase) method.

Possible solutions:
1. Remove forward parameter from this method (change findNextInPage(boolean 
forward) to findNextInPage()).
2. Use forward parameter in the body of this method.

Platform: Webclient source from Sep 04,2000.

Comment 1

17 years ago
reassign to ashu
Assignee: edburns → ashuk
(Assignee)

Comment 2

17 years ago
Thanks for catching this. However, I am not sure, the FindNextInPage functions
should have a "forward" input parameter. This is not in keeping with standard
behavior dislayed by either Netscape 4.x/Mozilla or IE.

_accept.

_Ashu
Status: NEW → ASSIGNED
(Assignee)

Comment 3

17 years ago
Created attachment 14416 [details] [diff] [review]
Proposed patch - diff -u for CurrentPageImpl.cpp
(Assignee)

Comment 4

17 years ago
Created attachment 14417 [details]
tar.gz of modified files

Comment 5

17 years ago
Comments on http://bugzilla.mozilla.org/showattachment.cgi?attach_id=14416 :

You're right it is not consistent to have "forward" param.  This is my fault.  
Nevertheless, let's check this in.  r=a=edburns.  Please file a separate bug 
about the incorrectness of the polarity of the API and assign it to ashu.
(Reporter)

Comment 6

17 years ago
I submitted the separate bug #52239
(Assignee)

Comment 7

17 years ago
Created attachment 14493 [details] [diff] [review]
Proposed patch - diff -u CurrentPageImpl.cpp
(Assignee)

Comment 8

17 years ago
FindNextInPage now uses forward parameter.
See attached patch. Checked into cvs.

_Ashu
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
(Reporter)

Updated

16 years ago
Status: RESOLVED → VERIFIED
(Reporter)

Comment 9

16 years ago
I mark it as verified.
Component: Java APIs to WebShell → Java APIs to WebShell
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.