Method findNextInPage(boolean forward) doesn't use its forward parameter (see
This method use forward parameter, which was set in findInPage(java.lang.String
stringToFind, boolean forward, boolean matchCase) method.
1. Remove forward parameter from this method (change findNextInPage(boolean
forward) to findNextInPage()).
2. Use forward parameter in the body of this method.
Platform: Webclient source from Sep 04,2000.
reassign to ashu
Thanks for catching this. However, I am not sure, the FindNextInPage functions
should have a "forward" input parameter. This is not in keeping with standard
behavior dislayed by either Netscape 4.x/Mozilla or IE.
Created attachment 14416 [details] [diff] [review]
Proposed patch - diff -u for CurrentPageImpl.cpp
Created attachment 14417 [details]
tar.gz of modified files
Comments on http://bugzilla.mozilla.org/showattachment.cgi?attach_id=14416 :
You're right it is not consistent to have "forward" param. This is my fault.
Nevertheless, let's check this in. r=a=edburns. Please file a separate bug
about the incorrectness of the polarity of the API and assign it to ashu.
I submitted the separate bug #52239
Created attachment 14493 [details] [diff] [review]
Proposed patch - diff -u CurrentPageImpl.cpp
FindNextInPage now uses forward parameter.
See attached patch. Checked into cvs.
I mark it as verified.