Closed Bug 513260 Opened 15 years ago Closed 15 years ago

Weave 0.6: Clicking "sign in" twice triggers alert: "Couldn't sign in: null"

Categories

(Firefox :: Sync, defect, P1)

Product:
Firefox
Component:
Sync
Platform:
x86
Linux
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: dholbert, Assigned: Mardak)

References

Details

Attachments

(1 file)

screenshot of alert
11.55 KB, image/png
Details
Attached image screenshot of alert — 
STEPS TO REPRODUCE:
 1. Visit about:weave
 2. Click "Sign in"
 3. Click "Sign in" again (while Weave is signing in)

ACTUAL RESULTS:
 An alert pops up, saying "Couldn't sign in: null"

This alert blocks all interaction with Firefox, and it pauses Weave's sign-in process, until it's acknowledged (by clicking "OK").
Suggested fix: The "sign in" button should probably be disabled while we're signing in.
Version info:
Weave 0.6
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a1pre) Gecko/20090826 Minefield/3.7a1pre
Blocks: 511688
Target Milestone: --- → 0.7
Priority: -- → P1
Priority: P1 → P2
Priority: P2 → P1
Assignee: nobody → thunder
http://hg.mozilla.org/labs/weave/rev/94b4591a2438
Disable the button before login and restore after (login:finish notifications). This should prevent the login lock from getting hit.
Assignee: thunder → edilee
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Verified fixed in Weave 0.7pre2.  Thanks for fixing this!
Status: RESOLVED → VERIFIED
Component: Firefox Sync: UI → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: